Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable RGB matrix effects for Drop CTRL with VIA #18291

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Enable RGB matrix effects for Drop CTRL with VIA #18291

merged 1 commit into from
Sep 7, 2022

Conversation

dsluo
Copy link
Contributor

@dsluo dsluo commented Sep 6, 2022

Description

Enabled all RGB matrix effects.

Basically copied #18041's changes for the Drop ALT.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Sep 6, 2022
@dsluo dsluo mentioned this pull request Sep 6, 2022
Merged
6 tasks
@zvecr zvecr merged commit 76910ee into qmk:master Sep 7, 2022
csrazvan added a commit to csrazvan/qmk_firmware that referenced this pull request Sep 8, 2022
@csrazvan
Merge remote-tracking branch 'upstream/master'
8f7ded9 
* upstream/master: (451 commits)
  Add Iris Rev. 6b (qmk#18307)
  GeonWorks Frog Mini Hotswap Layout Rework (qmk#18305)
  Update Iris VIA configuration (qmk#18306)
  [Keyboard] Wearhaus66 correct matrix (qmk#18284)
  enable RGB matrix effects for drop ctrl (qmk#18291)
  [Keymap] removed else in numlock led if statement (qmk#18304)
  added a new kprepublic/bm40hsrgb keymap called dan (qmk#18301)
  Delete my keymaps (qmk#18302)
  keymaps/stapelberg: keypad layer for multimedia keys, wake on escape (qmk#18295)
  Fungo rev1: fix QMK Configurator key sequence (qmk#18293)
  Discourage use of ENCODER_MAP at keyboard level (qmk#18286)
  Mars 6.5 Layout Additions (qmk#18282)
  Remove use of legacy keycode (qmk#18281)
  EU ISOlation: fix QMK Configurator key sequence (qmk#18272)
  Fix compilation error for GH60 satan HHKB 7u layout (qmk#18250)
  dyz60_hs Layout Additions (qmk#18261)
  Fix a couple of boards still using `usb.device_ver` (qmk#18258)
  Clean up data driven mappings syntax (qmk#18257)
  [Docs] Update 'Process Record' according to the code (qmk#18209)
  [Keyboard] RS60 Rev2 change to eeprom emulation (qmk#18201)
  ...
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@dsluo @ramonimbao
enable RGB matrix effects for drop ctrl (qmk#18291)
86cb9cb
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@dsluo @nolanseaton
enable RGB matrix effects for drop ctrl (qmk#18291)
5e16d5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

Assignees
No one assigned
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsluo @zvecr @keyboard-magpie