Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swoop keyboard #18436

Merged
merged 16 commits into from
Oct 13, 2022
Merged

Add Swoop keyboard #18436

merged 16 commits into from
Oct 13, 2022

Conversation

duckyb
Copy link
Contributor

@duckyb duckyb commented Sep 20, 2022

Adding support for Swoop

Description

Added the config/firmware and keymaps for the Swoop keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@duckyb duckyb changed the title Add swoop firmware Add Swoop keyboard Sep 20, 2022
keyboards/ferris/swoop/config.h Outdated Show resolved Hide resolved
keyboards/ferris/swoop/config.h Outdated Show resolved Hide resolved
keyboards/ferris/swoop/info.json Outdated Show resolved Hide resolved
keyboards/ferris/swoop/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/ferris/swoop/keymaps/default/rules.mk Outdated Show resolved Hide resolved
keyboards/ferris/swoop/keymaps/kyek/config.h Outdated Show resolved Hide resolved
keyboards/ferris/swoop/rules.mk Outdated Show resolved Hide resolved
keyboards/ferris/swoop/info.json Outdated Show resolved Hide resolved
duckyb and others added 3 commits September 21, 2022 02:16
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
@duckyb duckyb requested a review from zvecr September 21, 2022 00:50
@duckyb
Copy link
Contributor Author

duckyb commented Sep 21, 2022

The linting error doesn't seem to be a real problem from what I was able to find. In case it is, please let me know what I can do to fix it.

And thanks for the first review!

@zvecr
Copy link
Member

zvecr commented Sep 21, 2022

Given the keyboard doesnt implement the common physical layout, it would probably be best to move it outside the ferris parent folder. Otherwise more invasive changes will be required to remove the layout data at that parent level, which at this point seems unnecessary as its not from the original creator of the various ferris boards.

@duckyb
Copy link
Contributor Author

duckyb commented Sep 21, 2022

That makes sense. I'll discuss with the designer where it would be best to move it to and update the branch asap.

@duckyb
Copy link
Contributor Author

duckyb commented Sep 21, 2022

All done ✌🏻

keyboards/bluebell/swoop/config.h Outdated Show resolved Hide resolved
keyboards/bluebell/swoop/swoop.h Outdated Show resolved Hide resolved
keyboards/bluebell/swoop/rules.mk Show resolved Hide resolved
keyboards/bluebell/swoop/readme.md Outdated Show resolved Hide resolved
keyboards/bluebell/swoop/keymaps/default/keymap.c Outdated Show resolved Hide resolved
duckyb and others added 2 commits September 25, 2022 02:31
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
@duckyb
Copy link
Contributor Author

duckyb commented Sep 25, 2022

@drashna Thanks for looking at my PR. I have applied the requested changes.

@drashna drashna requested a review from a team September 26, 2022 03:42
@duckyb
Copy link
Contributor Author

duckyb commented Sep 28, 2022

Is that error compiling with @bbaserdem keymap something I have to deal with?

@fauxpark
Copy link
Member

No, it's an issue with their userspace code.

@drashna
Copy link
Member

drashna commented Sep 30, 2022

In general, we're mostly concerned about the default keymap compiling, and less, any keymap that is being added at the same time. Any community layouts, like this, are not considered.

@drashna drashna requested a review from a team September 30, 2022 03:16
@duckyb
Copy link
Contributor Author

duckyb commented Oct 7, 2022

I have people asking me how to configure the Swoop firmware in YouTube comments and I would like to avoid explaining how to setup QMK locally with a forked repository.

Any chance someone could review this soon? That way I could point people to qmk web configurator.

Thanks 🙏🏻

@duckyb
Copy link
Contributor Author

duckyb commented Oct 13, 2022

Anything else left to do?

@keyboard-magpie keyboard-magpie merged commit 4a30ea6 into qmk:master Oct 13, 2022
quinnyo pushed a commit to quinnyo/qmk_firmware that referenced this pull request Oct 21, 2022
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants