-
-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swoop keyboard #18436
Add Swoop keyboard #18436
Conversation
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
The linting error doesn't seem to be a real problem from what I was able to find. In case it is, please let me know what I can do to fix it. And thanks for the first review! |
Given the keyboard doesnt implement the common physical layout, it would probably be best to move it outside the ferris parent folder. Otherwise more invasive changes will be required to remove the layout data at that parent level, which at this point seems unnecessary as its not from the original creator of the various ferris boards. |
That makes sense. I'll discuss with the designer where it would be best to move it to and update the branch asap. |
This reverts commit 2ec883d.
All done ✌🏻 |
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna Thanks for looking at my PR. I have applied the requested changes. |
Is that error compiling with @bbaserdem keymap something I have to deal with? |
No, it's an issue with their userspace code. |
In general, we're mostly concerned about the default keymap compiling, and less, any keymap that is being added at the same time. Any community layouts, like this, are not considered. |
I have people asking me how to configure the Swoop firmware in YouTube comments and I would like to avoid explaining how to setup QMK locally with a forked repository. Any chance someone could review this soon? That way I could point people to qmk web configurator. Thanks 🙏🏻 |
Anything else left to do? |
Adding support for Swoop
Description
Added the config/firmware and keymaps for the Swoop keyboard.
Types of Changes
Issues Fixed or Closed by This PR
Checklist