Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mechlovin Foundation Configurator Cleanup #18500

Merged
merged 9 commits into from
Sep 27, 2022
Merged

Mechlovin Foundation Configurator Cleanup #18500

merged 9 commits into from
Sep 27, 2022

Conversation

noroadsleft
Copy link
Member

Description

Fixes some rendering issues with the keyboard in QMK Configurator, and adds a reference keymap.

Removes the tkl_nofrow portion from the layout names, as this board doesn't conform to QMK's tkl_nofrow_(ansi|iso) community layouts, due to the additional five keys on the left.

cc @mechlovin (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 27, 2022
@noroadsleft noroadsleft requested a review from a team September 27, 2022 02:26
@github-actions github-actions bot removed the via Adds via keymap and/or updates keyboard for via support label Sep 27, 2022
@zvecr
Copy link
Member

zvecr commented Sep 27, 2022

default_nofrow_iso -> default_iso maybe?

@drashna drashna requested a review from a team September 27, 2022 03:32
@drashna drashna merged commit 7d0c133 into qmk:master Sep 27, 2022
@noroadsleft noroadsleft deleted the rf/mechlovin_foundation branch September 27, 2022 21:28
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 2, 2022
@noroadsleft @tacahiroy
Mechlovin Foundation Configurator Cleanup (qmk#18500)
fad4215
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@noroadsleft
Mechlovin Foundation Configurator Cleanup (qmk#18500)
e7790a8
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@noroadsleft @ramonimbao
Mechlovin Foundation Configurator Cleanup (qmk#18500)
57bdd52
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@noroadsleft @nolanseaton
Mechlovin Foundation Configurator Cleanup (qmk#18500)
b51a35c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noroadsleft @zvecr @drashna @fauxpark