Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onekey: migrate some stuff to data driven #18502

Merged
merged 3 commits into from
Sep 29, 2022
Merged

Onekey: migrate some stuff to data driven #18502

merged 3 commits into from
Sep 29, 2022

Conversation

fauxpark
Copy link
Member

Description

  • Matrix pins
  • Backlight/RGBLight pins
  • MCU & Bootloader (using development_board where possible)
  • Set matrix for layout
  • Features in top-level info.json

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team September 27, 2022 09:01
@fauxpark fauxpark merged commit 45b5ed5 into qmk:master Sep 29, 2022
@fauxpark fauxpark deleted the onekey-data-driven branch September 29, 2022 18:23
@fauxpark fauxpark mentioned this pull request Sep 30, 2022
Merged
14 tasks
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 2, 2022
@fauxpark @tacahiroy
Onekey: migrate some stuff to data driven (qmk#18502)
3d7f06c
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@fauxpark
Onekey: migrate some stuff to data driven (qmk#18502)
6efdbf0
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @ramonimbao
Onekey: migrate some stuff to data driven (qmk#18502)
d79937d
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@fauxpark @nolanseaton
Onekey: migrate some stuff to data driven (qmk#18502)
99ad578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@daskygit daskygit daskygit approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @daskygit