Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a hardwired Dactylmacropad #18761

Merged
merged 49 commits into from
Nov 20, 2022
Merged

Added a hardwired Dactylmacropad #18761

merged 49 commits into from
Nov 20, 2022

Conversation

bwprobably
Copy link
Contributor

@bwprobably bwprobably commented Oct 18, 2022 •
edited by drashna
Loading

Adding in my hardwired macropad.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@bwprobably
Create keymap.c
5701ca8
@bwprobably
Add files via upload
0a565df
@bwprobably
Update keymap.c
0403e01
@bwprobably
Update keymap.c
a11904c 
Added "\" and "|"
Moved KC_MUTE
@bwprobably
Update keymap.c
950d457
@bwprobably
Update keymap.c
119d057
@bwprobably
Merge pull request #1 from qmk/master
03094e8 
updated pull from qmk master
@bwprobably
Rename keyboards/iris/keymaps/bwprobably/config.h to keyboards/keebio…
75b782a 
…/iris/keymaps/bwprobably/config.h
@bwprobably
Rename keyboards/iris/keymaps/bwprobably/keymap.c to keyboards/keebio…
7efa324 
…/iris/keymaps/bwprobably/keymap.c
@bwprobably
Rename keyboards/iris/keymaps/bwprobably/rules.mk to keyboards/keebio…
84dc2d6 
…/iris/keymaps/bwprobably/rules.mk
@bwprobably
Add files via upload
ec0f4a1
@bwprobably
Merge pull request #2 from qmk/master
ee89eb8 
Updated from Head Repo
@bwprobably
Create keymap.c
ee3ee91
@bwprobably
Add files via upload
419bf64
@bwprobably
Update config.h
973e195
@bwprobably
Merge branch 'qmk:master' into master
1f2405f
@bwprobably
Merge branch 'qmk:master' into master
e2237e6
@bwprobably
Merge branch 'qmk:master' into master
c463a2a
@bwprobably
added dactylmacropad
9223735
@bwprobably
Merge branch 'qmk:master' into master
32cb233
@bwprobably
Updated layout, and description
79fbf42
@bwprobably
Delete keyboards/handwired/SiCK-68_ProMicro directory
e7fea9e
drashna
drashna requested changes Oct 21, 2022
View reviewed changes
keyboards/handwired/dactylmacropad/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/dactylmacropad/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/dactylmacropad/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/dactylmacropad/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/dactylmacropad/keymap.c Outdated Show resolved Hide resolved
keyboards/keebio/iris/keymaps/bwprobably/keymap.c Outdated Show resolved Hide resolved
keyboards/keebio/iris/keymaps/bwprobably/config.h Outdated Show resolved Hide resolved
keyboards/handwired/dactylmacropad/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/dactylmacropad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/keebio/nyquist/keymaps/bwprobably/keymap.c Show resolved Hide resolved
bwprobably and others added 2 commits October 24, 2022 14:47
@bwprobably @drashna
Update keyboards/keebio/nyquist/keymaps/bwprobably/config.h
3fbc42f 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@bwprobably @drashna
Update keyboards/keebio/nyquist/keymaps/bwprobably/keymap.c
b7d94b5 
Co-authored-by: Drashna Jaelre <drashna@live.com>
drashna
drashna requested changes Oct 25, 2022
View reviewed changes
keyboards/handwired/dactylmacropad/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/dactylmacropad/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/dactylmacropad/readme.md Outdated Show resolved Hide resolved
bwprobably and others added 3 commits October 24, 2022 22:59
@bwprobably @drashna
Update keyboards/handwired/dactylmacropad/readme.md
a60810d 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@bwprobably @drashna
Update keyboards/handwired/dactylmacropad/readme.md
6f57c40 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@bwprobably @drashna
Update keyboards/handwired/dactylmacropad/readme.md
9cd92d1 
Didn't even cross my mind to link to sparkfun's my bad.

Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna drashna requested a review from a team October 25, 2022 06:30
fauxpark
fauxpark requested changes Oct 25, 2022
View reviewed changes
keyboards/handwired/dactylmacropad/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/dactylmacropad/keymap.c Outdated Show resolved Hide resolved
bwprobably
bwprobably commented Oct 28, 2022
View reviewed changes
Copy link
Contributor Author

@bwprobably bwprobably left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I got it all.

fauxpark
fauxpark requested changes Oct 29, 2022
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to narrow the scope of the Iris keymap to the revision you have, to avoid the compilation errors on the ones that have RGB Matrix enabled.

@bwprobably
Delete keyboards/keebio/iris/keymaps/bwprobably directory
0c7fc45 
I don't even know why I had this in this fork.
@bwprobably
Copy link
Contributor Author

I don't even know why I had my Iris in this fork. I just deleted the directory, the Dactyl is really the only reason for this pull request anyways.

bwprobably
bwprobably commented Nov 2, 2022
View reviewed changes
Copy link
Contributor Author

@bwprobably bwprobably left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just removed my iris folder.

bwprobably
bwprobably commented Nov 2, 2022
View reviewed changes
Copy link
Contributor Author

@bwprobably bwprobably left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@bwprobably @fauxpark
Update keyboards/handwired/dactylmacropad/readme.md
a5a80df 
Co-authored-by: Ryan <fauxpark@gmail.com>
@drashna drashna requested a review from a team November 19, 2022 19:48
@drashna drashna merged commit 0420a74 into qmk:master Nov 20, 2022
thystips pushed a commit to thystips/qmk_firmware that referenced this pull request Nov 24, 2022
@bwprobably @drashna
@fauxpark @thystips
[Keyboard] Add hardwired Dactyl macropad (qmk#18761)
2ed19de 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@bwprobably @drashna
@fauxpark @ramonimbao
[Keyboard] Add hardwired Dactyl macropad (qmk#18761)
59a19b9 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@bwprobably @drashna
@fauxpark @elpekenin
[Keyboard] Add hardwired Dactyl macropad (qmk#18761)
f1c6396 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@bwprobably @drashna
@fauxpark @crembz
[Keyboard] Add hardwired Dactyl macropad (qmk#18761)
583c5a5 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwprobably @drashna @fauxpark