Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wilba_tech: allow keymaps to override backlight_effect_indicators() #18791

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

ToyKeeper
Copy link
Contributor

Description

As the title says, this allows user keymaps to override backlight_effect_indicators() for keyboards which use Wilba Tech RGB.

I wanted to light things up in a custom way to show each key defined in each active non-base layer, plus extra lighting for modifier keys. With this one-line change, now I can.

The Wilba Tech code doesn't have a _kb() / _user() abstraction for customizing this, and I don't want to break anyone's keymaps by changing the API, so I just made the function weak.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team October 21, 2022 00:49
@zvecr zvecr merged commit 374d5d7 into qmk:develop Oct 21, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants