Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Black E6.5 keymap issues on QMK Configurator #18794

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Update Black E6.5 keymap issues on QMK Configurator #18794

merged 2 commits into from
Oct 21, 2022

Conversation

HorrorTroll
Copy link
Contributor

Description

Update Black E6.5 keymap issues on QMK Configurator. Sorry for the tag @noroadsleft, but can you help me take a look for it.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 21, 2022
@fauxpark fauxpark requested a review from a team October 21, 2022 03:56
@drashna drashna merged commit bd044ae into qmk:master Oct 21, 2022
@HorrorTroll HorrorTroll deleted the fix_black_e65 branch October 21, 2022 05:05
quinnyo pushed a commit to quinnyo/qmk_firmware that referenced this pull request Oct 21, 2022
@HorrorTroll @quinnyo
Update Black E6.5 keymap issues on QMK Configurator (qmk#18794)
435982d
@noroadsleft
Copy link
Member

Were these changes tested on actual hardware? That's the part I wanted to determine.

@HorrorTroll
Copy link
Contributor Author

@noroadsleft yes, it was re-tested and i don't see any problem after that

@noroadsleft
Copy link
Member

Thanks, that solves the issue and answers the questions I had.

TODO: update this keymap on the Configurator side - job for tomorrow-me.

tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 23, 2022
@HorrorTroll @tacahiroy
Update Black E6.5 keymap issues on QMK Configurator (qmk#18794)
3fffbb1
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@HorrorTroll
Update Black E6.5 keymap issues on QMK Configurator (qmk#18794)
636c084
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@HorrorTroll @ramonimbao
Update Black E6.5 keymap issues on QMK Configurator (qmk#18794)
54d31bb
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@HorrorTroll @nolanseaton
Update Black E6.5 keymap issues on QMK Configurator (qmk#18794)
8ccf45b
ChrisChrisLoLo pushed a commit to ChrisChrisLoLo/qmk_firmware that referenced this pull request Sep 2, 2023
@HorrorTroll @ChrisChrisLoLo
Update Black E6.5 keymap issues on QMK Configurator (qmk#18794)
9149800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HorrorTroll @noroadsleft @drashna @fauxpark