Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes for the Atreyu rev1 keyboard. #19098

Merged
merged 2 commits into from
Nov 20, 2022
Merged

Small fixes for the Atreyu rev1 keyboard. #19098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92f24f7
Small fixes for the Atreyu rev1 keyboard.
climent Nov 16, 2022
f44de8c
Fixed compile error by including atreyu.h and removing IS_LAYER_ON call.
climent Nov 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion keyboards/atreyu/rev1/info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
{"x":11, "y":4.25},
{"x":12, "y":4.15},
{"x":13, "y":4.125},
{"x": 14.5, "y": 4.5}
{"x": 15.5, "y": 4.5}
]
}
}
Expand Down
16 changes: 5 additions & 11 deletions keyboards/atreyu/rev1/rev1.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

climent marked this conversation as resolved.
Show resolved Hide resolved
#include "rev1.h"

#ifdef ENCODER_ENABLE
bool encoder_update_kb(uint8_t index, bool clockwise) {
if (!encoder_update_user(index, clockwise)) {
Expand All @@ -28,18 +30,10 @@ bool encoder_update_kb(uint8_t index, bool clockwise) {
}
}
if (index == 0) {
if (IS_LAYER_ON(_LOWER)) {
if (clockwise) {
tap_code(KC_WH_U);
} else {
tap_code(KC_WH_D);
}
if (clockwise) {
tap_code(KC_WH_U);
} else {
if (clockwise) {
tap_code(KC_VOLU);
} else {
tap_code(KC_VOLD);
}
tap_code(KC_WH_D);
}
}
return true;
Expand Down