docs: add a note about reflashing both halves for encoder resolution #19162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roobre
changed the title
drashna
reviewed
Nov 30, 2022
Co-authored-by: Drashna Jaelre <drashna@live.com>
drashna
approved these changes
Dec 21, 2022
tzarc
approved these changes
Dec 30, 2022
sbhal
pushed a commit
to sbhal/qmk_firmware
that referenced
this pull request
Dec 30, 2022
…mk#19162) Co-authored-by: Drashna Jaelre <drashna@live.com>
jasonisgraham
pushed a commit
to jasonisgraham/qmk_firmware
that referenced
this pull request
Jan 2, 2023
…mk#19162) Co-authored-by: Drashna Jaelre <drashna@live.com>
omikronik
pushed a commit
to omikronik/qmk_firmware
that referenced
this pull request
Jan 22, 2023
…mk#19162) Co-authored-by: Drashna Jaelre <drashna@live.com>
ideas32
pushed a commit
to ideas32/qmk_firmware
that referenced
this pull request
Jan 25, 2023
…mk#19162) Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentations do not mention that in order to modify encoder resolution, the half that has the encoder also needs to be reflashed, not only the master half.
In hindsight this is obvious and submitting this PR feels a bit like accepting my own stupidity, but... Well, it might save other dim fellows the couple hours of research and debugging I went through 🤦🏻♀️
Types of Changes
Issues Fixed or Closed by This PR
Checklist