Migrate 'make git-submodule' to CLI command #19479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzarc
approved these changes
Jan 2, 2023
sigprof
added a commit
to sigprof/qmk-nix-support
that referenced
this pull request
Jan 5, 2023
The `develop` branch had switched from `make git-submodule` to a CLI command (`qmk git-submodule`; qmk/qmk_firmware#19479); the old make target is still supported, but calls `qmk git-submodule`, which requires the Nix shell environment. Swap the “Build the Nix shell environment” and “Update submodules” steps, and invoke `make git-submodule` through `nix-shell` (the new `qmk git-submodule` command is not yet supported in the `master` branch).
omikronik
pushed a commit
to omikronik/qmk_firmware
that referenced
this pull request
Jan 22, 2023
sigprof
added a commit
to sigprof/nix-devenv-qmk
that referenced
this pull request
Mar 5, 2023
QMK now implements `make git-submodule` using the `qmk git-submodule` CLI command (qmk/qmk_firmware#19479). Move the “Update submodules” step after the “Build the Nix shell environment” step, so that the QMK CLI is available, and run `make git-submodule` through `nix-shell`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Will remove the need for users to manually
cdto the qmk_firmware folder, frequently a missed step.maketargets still exist to maintain existing compatibility.Types of Changes
Checklist