Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cmp checks from Makefile #19480

Merged
merged 4 commits into from
Jan 2, 2023
Merged

Remove cmp checks from Makefile #19480

merged 4 commits into from
Jan 2, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 2, 2023

Description

We dont check for any other tools, even the important ones such as compilers, so this stands out as a bit pointless. If important enough, why is it not part of qmk doctor?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jan 2, 2023
@zvecr zvecr requested a review from a team January 2, 2023 21:02
@zvecr zvecr merged commit 20ee103 into develop Jan 2, 2023
@zvecr zvecr deleted the zvecr-patch-1 branch January 2, 2023 23:11
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants