Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add f303 to tinyuf2 bootloader support #19620

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Add f303 to tinyuf2 bootloader support #19620

merged 2 commits into from
Jan 18, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 18, 2023 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jan 18, 2023
@zvecr zvecr changed the title Add f303 support to tinyuf2 bootloader Add f303 support to tinyuf2 support Jan 18, 2023
@zvecr zvecr requested a review from a team January 18, 2023 02:48
@zvecr zvecr changed the title Add f303 support to tinyuf2 support Add f303 to tinyuf2 bootloader support Jan 18, 2023
KarlK90
KarlK90 approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the flashing docs could use an update though as the F4xx are no longer the only option. https://github.com/qmk/qmk_firmware/blob/develop/docs/flashing.md?plain=1#L327

KarlK90
KarlK90 approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Feel free to merge from my side.

@zvecr zvecr merged commit 82a94ea into qmk:develop Jan 18, 2023
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@zvecr @omikronik
Add f303 to tinyuf2 bootloader support (qmk#19620)
1918f69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarlK90 KarlK90 KarlK90 approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @KarlK90