Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix converter alias after 19603 #19644

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Fix converter alias after 19603 #19644

merged 1 commit into from
Jan 20, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 20, 2023 •
edited
Loading

Description

Was trying to handle the case where PLATFORM_PATH has parents, but for now its easier to handle folders not having trailing slashes? Most of this logic should go with the move to DD converters anyway.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team January 20, 2023 02:33
@zvecr zvecr added the bug label Jan 20, 2023
@zvecr zvecr merged commit 27504d9 into develop Jan 20, 2023
@fauxpark fauxpark deleted the zvecr-patch-2 branch January 20, 2023 02:50
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@zvecr @omikronik
Fix converter alias after 19603 (qmk#19644)
218bdfd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @fauxpark