Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userspace/community layout fixes #19998

Merged
merged 4 commits into from
Mar 15, 2023
Merged

Conversation

lesshonor
Copy link
Contributor

@lesshonor lesshonor commented Mar 2, 2023

Description

These userspaces/layouts are causing CI build failures on newly-submitted boards that implement particular community layouts. Changeset deliberately kept minimal.

@mechmerlin
@Talljoe

(...jack appears to be the creator of the unxmaal layout? not sure that's worth a ping)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

CI failures on #19958, #19943, #19688, #17544...

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the keymap label Mar 2, 2023
@drashna drashna requested a review from a team March 10, 2023 07:49
@keyboard-magpie keyboard-magpie merged commit 70bf714 into qmk:develop Mar 15, 2023
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
* fixup: improve AVR detection for 60_iso/unxmaal

* fixup: moved TAP_CODE_DELAY to mechmerlin/config.h

* fixup: move talljoe.c to INTROSPECTION_KEYMAP_C

* fixup: AVR/RGBLIGHT criteria for 60_iso/unxmaal
@lesshonor lesshonor deleted the users-fix branch June 28, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants