Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up duplication of MIN/MAX fallback implementations #20236

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Tidy up duplication of MIN/MAX fallback implementations #20236

merged 2 commits into from
Mar 23, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 23, 2023 •
edited
Loading

Description

Be it only small code chunks, we have common fallbacks so these shouldnt be duplicated everywhere.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Mar 23, 2023
@zvecr zvecr merged commit b01dc36 into qmk:develop Mar 23, 2023
@zvecr zvecr deleted the min_max_tidy branch March 23, 2023 05:30
nicsuzor pushed a commit to nicsuzor/qmk_firmware that referenced this pull request Mar 28, 2023
@zvecr @nicsuzor
Tidy up duplication of MIN/MAX fallback implementations (qmk#20236)
ca6d22e
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@zvecr @coquizen
Tidy up duplication of MIN/MAX fallback implementations (qmk#20236)
0fb51c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @tzarc @fauxpark