Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate keymap dd keycodes to header #20273

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Generate keymap dd keycodes to header #20273

merged 1 commit into from
Jun 17, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 27, 2023

Description

Now keymap.h is unused, we can re-purpose it for a sibling to keymap.c when processing a keymap.json.

This will allow additional files to include the header, and implement with process_record_user.

In the future this header can be reused for more user facing items like tap dance, unicode, etc.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command core python labels Mar 27, 2023
@zvecr zvecr mentioned this pull request Mar 27, 2023
15 tasks
@zvecr zvecr changed the title Generate keycodes to header Generate keymap dd keycodes to header Mar 27, 2023
@zvecr zvecr marked this pull request as ready for review March 28, 2023 01:54
@zvecr zvecr marked this pull request as draft March 28, 2023 02:03
@zvecr zvecr mentioned this pull request May 29, 2023
14 tasks
@zvecr zvecr marked this pull request as ready for review May 11, 2024 15:27
@tzarc tzarc requested a review from a team June 17, 2024 12:25
@zvecr zvecr merged commit 938badc into qmk:develop Jun 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants