Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable specific warnings to mitigate compilation problems with KEEP_INTERMEDIATES=yes. #20339

Merged
merged 9 commits into from
Apr 5, 2023
+25 −6
Merged

Disable specific warnings to mitigate compilation problems with KEEP_INTERMEDIATES=yes. #20339

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a498f22
Disable -Wtautological-compare to mitigate compilation problems.
tzarc Apr 4, 2023
44834ff
Disable -Wmaybe-uninitialized to mitigate compilation problems.
tzarc Apr 4, 2023
cba6027
Fix misc build.
tzarc Apr 4, 2023
8a5a77a
Fix misc build.
tzarc Apr 4, 2023
370e09d
Disable -Wtautological-compare to mitigate compilation problems.
tzarc Apr 4, 2023
add42e4
Fix misc build.
tzarc Apr 4, 2023
2596ccd
Hoist warning ignore to wait.h
tzarc Apr 4, 2023
b9b174d
Remove added newlines.
tzarc Apr 4, 2023
44e05d0
Review comments.
tzarc Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Hoist warning ignore to wait.h
  • Loading branch information
@tzarc
tzarc committed Apr 4, 2023
commit 2596ccd448f17715f25a23198b2aa5a418484127
4 changes: 4 additions & 0 deletions platforms/avr/_wait.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@
*/
#pragma once

// Need to disable GCC's "maybe-uninitialized" warning for this file, as it causes issues when running `KEEP_INTERMEDIATES=yes`.
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
#include <util/delay.h>
#pragma GCC diagnostic pop

// http://ww1.microchip.com/downloads/en/devicedoc/atmel-0856-avr-instruction-set-manual.pdf
// page 22: Table 4-2. Arithmetic and Logic Instructions
Expand Down
7 changes: 2 additions & 5 deletions tmk_core/protocol/usb_hid/override_wiring.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,7 @@
*/
#define __DELAY_BACKWARD_COMPATIBLE__

// Need to disable GCC's "maybe-uninitialized" warning for this file, as it causes issues when running `KEEP_INTERMEDIATES=yes`.
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
#include <util/delay.h>
#pragma GCC diagnostic pop
#include <wait.h>
tzarc marked this conversation as resolved.
Show resolved Hide resolved

#include "platforms/timer.h"

Expand All @@ -32,3 +28,4 @@ void init(void)
{
timer_init();
}