Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize dactyl_manuform/dmote keyboard #20427

Merged
merged 21 commits into from
Sep 21, 2023
Merged

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Apr 12, 2023

Description

  • dmote dir moved up one level
    • alias added
  • folder structure changed to match Keyboard PR guidance
    • file names changed to match folder structure
    • layout macro name renamed
  • `layout and keymaps reordered/modernised to be uniform with other split keyboards
  • readme.md updated

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team April 15, 2023 09:59
dunk2k and others added 8 commits June 20, 2023 11:46
- image link removed
amend to use `development_board` element
1. `dmote` doesn't confirm to dactyl manuform variation convention
2. Other keyboards by veikman, e.g. `concertina`, reside in `handwired` dir
@dunk2k
Copy link
Contributor Author

dunk2k commented Jun 20, 2023

@qmk/collaborators
This PR is doing something undesired with submodule 'chibios' and my git knowledge, especially with submodules, isn't versed enough to remove change to said submodule.

Should I cancel this PR and create a new PR that is branched from an updated 'develop' branch?

@drashna
Copy link
Member

drashna commented Jul 4, 2023

git checkout @@your-branch@@
# for each of the problematic repo's:
cd lib/@@name@@
git checkout qmk-develop

data/mappings/keyboard_aliases.hjson Outdated Show resolved Hide resolved
Co-authored-by: Ryan <fauxpark@gmail.com>
@drashna drashna merged commit 29ffe80 into qmk:develop Sep 21, 2023
3 checks passed
@dunk2k dunk2k deleted the dmote_clean branch October 6, 2023 12:54
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
Co-authored-by: Ryan <fauxpark@gmail.com>
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
Co-authored-by: Ryan <fauxpark@gmail.com>
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
Co-authored-by: Ryan <fauxpark@gmail.com>
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants