Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JJ40 updates #2056

Merged
merged 10 commits into from Nov 27, 2017
Merged

JJ40 updates #2056

merged 10 commits into from Nov 27, 2017

Conversation

ghost
Copy link

@ghost ghost commented Nov 25, 2017

added backlight pin, readme boot default key etc.

@jackhumbert
Copy link
Member

It looks like your build is failing in Travis - does it build locally?

Also, would you mind renaming your keymap? We don't really have an official policy on profanity yet, but we'd like to keep things family-friendly!

@drashna
Copy link
Member

drashna commented Nov 26, 2017

Looks like it's failing due to this: #2057

@ghost
Copy link
Author

ghost commented Nov 26, 2017

Sorry about that name, it was from a party we had a while ago and was a bad choice.

  • updated readme and folder names
  • set NKRO flag to no, it compiles locally now.
    Please review.

@jackhumbert
Copy link
Member

Cool! It looks like your JJ40.sublime-workspace snuck it - would you mind removing that?

The info.json also needs updated for the JJ40 :)

@ghost
Copy link
Author

ghost commented Nov 26, 2017

updated.
info.json removed (thought it might help troubleshoot NKRO). I'm new to qmk.

@jackhumbert
Copy link
Member

Awesome! Thanks :)

@jackhumbert jackhumbert merged commit 9113f33 into qmk:master Nov 27, 2017
LovesTha pushed a commit to LovesTha/qmk_firmware that referenced this pull request Jul 24, 2018
* my bits

* fixed
safdb

* readme

* readme

* better name, fixed compile error

* fixed matrix user

* cleanup
@noroadsleft noroadsleft mentioned this pull request Apr 7, 2019
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants