Remove use of layout macros for music_map
#20634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Apr 30, 2023
tzarc
approved these changes
Apr 30, 2023
coquizen
pushed a commit
to coquizen/qmk_firmware
that referenced
this pull request
Jun 22, 2023
39 tasks
jpskenn
added a commit
to jpskenn/qmk_firmware
that referenced
this pull request
Nov 4, 2023
autoferrit
pushed a commit
to SpaceRockMedia/bastardkb-qmk
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
unison/v04:viafails on develop because the layout macro is not visible to the .c file.Previously I've simply added
#include QMK_KEYBOARD_Hbut it feels like a bit of a hack; instead I think it's probably better to not use the layout macro as it's more explicit. The downside is that for boards with multiple revisions, it has to be duplicated for each one, if the matrix positions differ.Types of Changes
Issues Fixed or Closed by This PR
Checklist