Ciaanh kanagawa

[Ciaanh]

Add Kanagawa keyboard definition

Description

Kanagawa is a 75% keyboard with RGB matrix, rotary encoder, ISO/ANSI compatibility with a split spacebar and powered by a Raspberry Pico

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[zvecr]

• add keyboards/ciaanh/kanagawa/ansi/keymaps/default/rules.mk and keyboards/ciaanh/kanagawa/iso/keymaps/default/rules.mk to enable encoder map
• iso via keymap?

[Ciaanh]

Thanks for the reviews, regarding handling the iso layout via keymap I first thought of it but had a hard time handling the rgb matrix differences.
Is it acceptable to move the g_led_config declaration inside the keymap.c ?

[zvecr]

Is it acceptable to move the g_led_config declaration inside the keymap.c ?

Never, it would stop the PR from being accepted.

Its mostly implemented as 2 separate keyboards, there shouldnt be any issues. The only requirement will be a different product id for each revision (and a via config file for each).

• add keyboards/ciaanh/kanagawa/ansi/keymaps/default/rules.mk and keyboards/ciaanh/kanagawa/iso/keymaps/default/rules.mk to enable encoder map

This still hasnt been completed.

[github-actions]

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.