Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor amendment to bcat userspace to prevent build failure #21205

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Minor amendment to bcat userspace to prevent build failure #21205

merged 3 commits into from
Jul 7, 2023

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Jun 10, 2023 •
edited
Loading

Description

added quantum_keycodes.h to [userspace].h file

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 requested changes Jun 10, 2023
View reviewed changes
users/bcat/bcat.h Outdated Show resolved Hide resolved
@dunk2k dunk2k requested a review from waffle87 June 10, 2023 22:33
zvecr
zvecr reviewed Jun 11, 2023
View reviewed changes
users/bcat/bcat.h Outdated Show resolved Hide resolved
@dunk2k @zvecr
Update users/bcat/bcat.h
d9dd601 
Co-authored-by: Joel Challis <git@zvecr.com>
@zvecr zvecr removed the invalid label Jun 11, 2023
@dunk2k dunk2k mentioned this pull request Jul 6, 2023
Closed
14 tasks
@tzarc tzarc merged commit f466fb8 into qmk:develop Jul 7, 2023
@dunk2k dunk2k deleted the bcat_fix branch July 7, 2023 17:04
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@dunk2k @zvecr @jesperhellberg
Minor amendment to bcat userspace to prevent build failure (qmk#21205)
4a430b3 
Co-authored-by: Joel Challis <git@zvecr.com>
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@dunk2k @zvecr @thismarvin
Minor amendment to bcat userspace to prevent build failure (qmk#21205)
587c312 
Co-authored-by: Joel Challis <git@zvecr.com>
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@dunk2k @zvecr @akeep
Minor amendment to bcat userspace to prevent build failure (qmk#21205)
37eb1ab 
Co-authored-by: Joel Challis <git@zvecr.com>
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@dunk2k @zvecr @csolje
Minor amendment to bcat userspace to prevent build failure (qmk#21205)
90b9548 
Co-authored-by: Joel Challis <git@zvecr.com>
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@dunk2k @zvecr @autoferrit
Minor amendment to bcat userspace to prevent build failure (qmk#21205)
9a4a020 
Co-authored-by: Joel Challis <git@zvecr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr left review comments

@tzarc tzarc tzarc approved these changes

@waffle87 waffle87 waffle87 approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dunk2k @tzarc @zvecr @waffle87