Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Skyloong/GK75 Q1 keyboard. #21573

Open
wants to merge 44 commits into
base: develop
Choose a base branch
from
Open

Add Skyloong/GK75 Q1 keyboard. #21573

wants to merge 44 commits into from
+1,299 −1

Conversation

JZ-Skyloong
Copy link
Contributor

It's a 75% key layout keyboard of skyloong.

Description

This keyboard have 2 PCBAS to select. They are ansi_encoder pcba and iso_encoder pcba.
The right-top 4 key bars can be installed or replaced with a skyloong developed encoder module. Encoder module and key mounting sizes are fully compatible.
Space bar can be splited.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 21, 2023
sigprof
sigprof requested changes Jul 21, 2023
View reviewed changes
keyboards/skyloong/gk75/q1/mcuconf.h Outdated Show resolved Hide resolved
keyboards/skyloong/gk75/q1/info.json Outdated Show resolved Hide resolved
keyboards/skyloong/gk75/q1/config.h Outdated Show resolved Hide resolved
@JZ-Skyloong JZ-Skyloong requested a review from sigprof July 22, 2023 05:57
@JZ-Skyloong
Copy link
Contributor Author

What can I do for this PR else?

drashna
drashna requested changes Sep 15, 2023
View reviewed changes
keyboards/skyloong/gk75/q1/config.h Outdated Show resolved Hide resolved
keyboards/skyloong/gk75/q1/config.h Outdated Show resolved Hide resolved
keyboards/skyloong/gk75/q1/config.h Outdated Show resolved Hide resolved
keyboards/skyloong/gk75/q1/q1.c Show resolved Hide resolved
keyboards/skyloong/gk75/q1/q1.c Outdated Show resolved Hide resolved
drashna
drashna requested changes Sep 23, 2023
View reviewed changes
keyboards/skyloong/gk75/q1/config.h Outdated Show resolved Hide resolved
waffle87
waffle87 requested changes Oct 23, 2023
View reviewed changes
keyboards/skyloong/gk75/q1/ansi_encoder/rules.mk Outdated Show resolved Hide resolved
keyboards/skyloong/gk75/q1/config.h Outdated Show resolved Hide resolved
keyboards/skyloong/gk75/q1/iso_encoder/rules.mk Outdated Show resolved Hide resolved
@github-actions github-actions bot added core documentation dd Data Driven Changes labels Nov 2, 2023
@github-actions github-actions bot removed core documentation dd Data Driven Changes labels Nov 2, 2023
@JZ-Skyloong
Copy link
Contributor Author

Would you please check and merge it? @sigprof @drashna @waffle87

@drashna drashna requested a review from a team December 23, 2023 07:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Feb 7, 2024
@JZ-Skyloong
Copy link
Contributor Author

Would you please merge it? @waffle87

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Feb 23, 2024
fauxpark
fauxpark requested changes Feb 24, 2024
View reviewed changes
keyboards/skyloong/gk75/q1/config.h Outdated Show resolved Hide resolved
keyboards/skyloong/gk75/q1/q1.c Outdated Show resolved Hide resolved
keyboards/skyloong/gk75/q1/q1.c Outdated Show resolved Hide resolved
keyboards/skyloong/gk75/q1/q1.c Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Mar 11, 2024
View reviewed changes
keyboards/skyloong/gk75/q1/config.h Outdated Show resolved Hide resolved
keyboards/skyloong/gk75/q1/config.h Outdated Show resolved Hide resolved
keyboards/skyloong/gk75/q1/info.json Show resolved Hide resolved
JZ-Skyloong and others added 28 commits June 19, 2024 15:52
@JZ-Skyloong @NaturalZh
add disable RGB when suspended
cd8bd53
@JZ-Skyloong @NaturalZh
add rgb matrix custom effect
60a6420
@JZ-Skyloong @NaturalZh
modified keymaps.
a7c7c35
@JZ-Skyloong @NaturalZh
correct rgb matrix custom effect function
cb4da1f
@JZ-Skyloong @NaturalZh
Enable encoder map in default keymap.
a85d4a4
@JZ-Skyloong @NaturalZh
Modified encoder map keycode;add SIGNALRGB_SUPPORT_ENABLE = yes in ru…
2ae6d66 
…le.mk
@JZ-Skyloong @NaturalZh
Correct split space wide
249b9c7
@JZ-Skyloong @NaturalZh
update info.json for layout name
ef096d0
@JZ-Skyloong @NaturalZh
Update keymaps
a8bd19e
@JZ-Skyloong @waffle87 @NaturalZh
Update keyboards/skyloong/gk75/q1/config.h
31c5357 
OK, I see. Thank you.

Co-authored-by: jack <0x6a73@protonmail.com>
@JZ-Skyloong @waffle87 @NaturalZh
Update keyboards/skyloong/gk75/q1/info.json
6a634a7 
OK, I see. Thank you.

Co-authored-by: jack <0x6a73@protonmail.com>
@JZ-Skyloong @waffle87 @NaturalZh
Update keyboards/skyloong/gk75/q1/ansi_encoder/rules.mk
c9b7c55 
OK, Thanks.

Co-authored-by: jack <0x6a73@protonmail.com>
@JZ-Skyloong @waffle87 @NaturalZh
Update keyboards/skyloong/gk75/q1/iso_encoder/rules.mk
ae36ce8 
OK.

Co-authored-by: jack <0x6a73@protonmail.com>
@JZ-Skyloong @NaturalZh
Add shut down function and delete LED number define.
25e699c
@JZ-Skyloong @NaturalZh
Update keyboards/skyloong/gk75/q1 for VAI keycode function.
ca89546
@JZ-Skyloong @NaturalZh
modified debounce time
0cab969
@JZ-Skyloong @NaturalZh
update gk75_q1 keyboards because core updated.
1e0f3e4
@JZ-Skyloong @fauxpark @NaturalZh
Update keyboards/skyloong/gk75/q1/config.h
cc59588 
OK, I see . Thank you.

Co-authored-by: Ryan <fauxpark@gmail.com>
@JZ-Skyloong @fauxpark @NaturalZh
Update keyboards/skyloong/gk75/q1/q1.c
f22ee10 
OK, I see. Thank you.

Co-authored-by: Ryan <fauxpark@gmail.com>
@JZ-Skyloong @fauxpark @NaturalZh
Update keyboards/skyloong/gk75/q1/q1.c
9f1cf8e 
OK, thank you.

Co-authored-by: Ryan <fauxpark@gmail.com>
@JZ-Skyloong @NaturalZh
update skyloong/gk75/q1/q1.c
e0e71dc
@NaturalZh
Update skyloong/gk75/q1 keyboard to add win lock function
e345896
@JZ-Skyloong @fauxpark @NaturalZh
Update keyboards/skyloong/gk75/q1/config.h
1764bf0 
OK, Thank you.

Co-authored-by: Ryan <fauxpark@gmail.com>
@JZ-Skyloong @fauxpark @NaturalZh
Update keyboards/skyloong/gk75/q1/config.h
cb85534 
OK, Thank you.

Co-authored-by: Ryan <fauxpark@gmail.com>
@NaturalZh
update skyloong/gk75/q1/info.json
30ee4e1
@NaturalZh
modified the files witch name is info.json to keyboard.json
1e48e19
@NaturalZh
modified keyboards/skyloong/gk75/q1/info.json
46f761a
@NaturalZh
update skyloong/gk75/q1/info.json and rebased to newest develop
c64066c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigprof sigprof Awaiting requested review from sigprof

@waffle87 waffle87 Awaiting requested review from waffle87

@drashna drashna Awaiting requested review from drashna

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@JZ-Skyloong @NaturalZh @sigprof @drashna @fauxpark @waffle87