Add Dark Project KD87b LTD

[SHVD3x]

Add new Dark Project KD87b LTD keyboard.

Description

This PR features custom matrix scanning code with adaptive scan rate and anti-ghosting. It will be supplemented with a gaming keymap with eager debounce algo.

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[lesshonor]

I can't speak to any of the custom matrix code, but please run qmk format-c on this file. The linter is complaining about the line endings.

[SHVD3x]

I did it with no effect, I think the file on github is bugged because it always shows commit changes if I trying to edit it even if I don't make any. I have identical copyright label in another PR which passes lint, strange behavior.

[lesshonor]

My mistake, I gave you the wrong command. qmk format-text will correct the CRLF (Windows) line endings. A good text editor can do this too.

This repository accepts LF (Unix) line endings only.

[SHVD3x]

This didn't resolve the issue with linter.

[zvecr]

This PR features custom matrix scanning code with adaptive scan rate and anti-ghosting.

Due to the maintenance cost involved, this code should be removed and the core implementation used instead.

[SHVD3x]

This code is simple and efficient, it uses basic C constructions and PAL to improve it's reliability. It also takes into account the individual features of the structure and layout of the keyboard. The main algorithm of key scanning is robust and this is probably the only way to register keypresses for this hardware configuration. Also this code provides much higher scanning rates than core implementation.

[drashna]

But is it necessary, or just an optimization?

[SHVD3x]

Now adding custom matrix is mandatory because it resolves problem with ghosting and phantom keypresses on some boards.
I will support this code and keep it up to QMK standarts.
This applies to both KD83a LTD and KD87b LTD.

[zvecr]

From my perspective, still needs to use core and wouldn't be accepted till the code is removed.

[drashna]

QMK already has some options to detect and handle ghosting (MATRIX_HAS_GHOST), and phantom keypresses can be solved with debouncing. So, I'm not sure why a custom matrix would be necessary. And most of the comments really indicate that this is an optimization, rather than a requirement.

[github-actions]

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

[github-actions]

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

[github-actions]

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]