Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amend 60_* community_layouts in keyboards/ #21831

Closed
wants to merge 117 commits into from
Closed

amend 60_* community_layouts in keyboards/ #21831

wants to merge 117 commits into from

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Aug 24, 2023 •
edited
Loading

Description

encompasses all 60_* community layouts, where applicable:

  • added community_layouts to keyboards
  • appended layouts with community layouts to keyboards where LAYOUT_all and/or matrix_diagram.md information available
  • correct ISO key sequence in iso layouts

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@dunk2k dunk2k marked this pull request as ready for review August 25, 2023 09:38
@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Aug 26, 2023
@dunk2k dunk2k changed the base branch from develop to master September 5, 2023 18:36
@drashna drashna requested a review from a team September 21, 2023 04:25
@dunk2k dunk2k changed the title amend 60_(abnt2|ansi|iso|hhkb)* community_layouts in keyboards/ amend 60_* community_layouts in keyboards/ Oct 2, 2023
@dunk2k dunk2k mentioned this pull request Oct 3, 2023
Merged
14 tasks
@dunk2k dunk2k force-pushed the comm_60 branch 2 times, most recently from b83371d to af2cd78 Compare November 10, 2023 10:21
@dunk2k
Copy link
Contributor Author

dunk2k commented Dec 6, 2023

@yj7272098
Hi, if you're able, and it would be greatly appreciated, could you relay/complete matrix co-ordinates for ?? keys in keyboards/playkbtw/pk60/matrix_diagram.md?

@dunk2k dunk2k changed the base branch from master to develop December 8, 2023 14:05
@yj7272098
Copy link
Contributor

@yj7272098 Hi, if you're able, and it would be greatly appreciated, could you relay/complete matrix co-ordinates for ?? keys in keyboards/playkbtw/pk60/matrix_diagram.md?

Sorry I've been busy for the next project. I'll have to check out the new matrix form first.

@dunk2k dunk2k marked this pull request as draft January 6, 2024 17:01
dunk2k added a commit to dunk2k/qmk_firmware that referenced this pull request Jan 6, 2024
@dunk2k
0-9 from qmk#21831
5c6e20e
This was referenced Jan 6, 2024
Open
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@dunk2k
Copy link
Contributor Author

dunk2k commented Jan 7, 2024 •
edited
Loading

PR split into smaller PRs

@dunk2k dunk2k closed this Jan 7, 2024
@dunk2k dunk2k deleted the comm_60 branch January 7, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dunk2k @yj7272098 @fauxpark