Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Community Layouts for LAYOUT keyboards #21855

Closed
wants to merge 154 commits into from
Closed

add Community Layouts for LAYOUT keyboards #21855

wants to merge 154 commits into from

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Aug 28, 2023 •
edited
Loading

Description

Assign matching community_layout(s) to keyboards with LAYOUT macro

  • where applicable; utilise layout_aliases to match layout name to Community Layout name

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 28, 2023
@dunk2k dunk2k marked this pull request as ready for review August 29, 2023 15:27
@drashna drashna requested a review from a team August 30, 2023 01:46
fauxpark
fauxpark requested changes Aug 31, 2023
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should ideally be swapped around, there is no functional change.

@dunk2k
Copy link
Contributor Author

dunk2k commented Sep 1, 2023

These should ideally be swapped around, there is no functional change.

Apologies, could you elaborate on "swapped around"?

@fauxpark
Copy link
Member

fauxpark commented Sep 1, 2023

Layout aliases where the alias is a community layout name and the target is not should be swapped (as the idea is to remove the aliases at some later point). Such as:

    "layout_aliases": {
        "LAYOUT_60_ansi": "LAYOUT_ansi_61"
    },

@dunk2k dunk2k requested a review from fauxpark September 2, 2023 16:43
@dunk2k dunk2k changed the base branch from develop to master September 5, 2023 17:58
dunk2k and others added 20 commits September 5, 2023 19:00
@dunk2k
0 - handwired/
dfb2b75
@dunk2k
lint check corrections
338f17d
@dunk2k
build fixes applied
f5b24dd
@dunk2k
revert handwired/arrow_pad/pad_21
5aa9054
@dunk2k
helix/pico - n
181621b
@dunk2k
linting error fixed
014ffce
@dunk2k
CI build fixes applied
dcaf725
@dunk2k
m - s
b8c22b8
@dunk2k
lint check fix
afbc3bf
@dunk2k
t - z
a5aebef
@dunk2k
add keychron boards
a20adc2
@dunk2k
add keychron q60
39c2202
@dunk2k
keychron, remove layout_aliases
7876da0
@tzarc @dunk2k
Branch point for 20230827 breaking change.
193972a
@JohnAZoidberg @dunk2k
is31fl3741: Allow changing config register (qmk#21861)
4cfe048 
When not all SW pins are used, it's useful to disable those that aren't.
Can reduce audible noise.

```
Layout:
D7:D4 D3  D2:D1 D0
SWD   LGC OSDE  SSD

SWS: SWx Setting. Change how many SW pins are active
LGC: H/L Logic
SSD: Software Shutdown Control
```

Signed-off-by: Daniel Schaefer <dhs@frame.work>
@noroadsleft @dunk2k
1UpKeyboards Pi60 Layout Additions (qmk#21874)
b80f962 
* [refactor] rename LAYOUT_60_ansi to LAYOUT_all

* [enhancement] add LAYOUT_60_ansi

* [enhancement] add LAYOUT_60_ansi_split_bs_rshift

* [enhancement] add LAYOUT_60_ansi_tsangan

* [enhancement] add LAYOUT_60_tsangan_hhkb

* [enhancement] add LAYOUT_60_iso

* [enhancement] add LAYOUT_60_iso_split_bs_rshift

* [enhancement] add LAYOUT_60_iso_tsangan

* [enhancement] add LAYOUT_60_iso_tsangan_split_bs_rshift

* [enhancement] enable Community Layout support

* [enhancement] add LAYOUT_60_hhkb

* [enhancement] add LAYOUT_60_ansi_arrow

* [enhancement] add LAYOUT_60_iso_arrow

* [docs] add layout/matrix diagram
@dunk2k
revert ah/haven80/hotswap|solder|keymaps
2b6eb0a
@dunk2k
reversion
0dc662a
@dunk2k
reversion
84a6faa
@dunk2k
layout aliases added - part aine
99cc05c
@dunk2k dunk2k changed the base branch from master to develop March 19, 2024 16:25
@dunk2k dunk2k changed the title amend community layouts for LAYOUT boards add Community Layouts for LAYOUT boards Apr 12, 2024
@dunk2k dunk2k changed the title add Community Layouts for LAYOUT boards add Community Layouts for LAYOUT keyboards Apr 12, 2024
This was referenced Apr 12, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@dunk2k
Copy link
Contributor Author

dunk2k commented Apr 12, 2024

this PR segmented alphabetically into smaller PRs

@dunk2k dunk2k closed this Apr 12, 2024
@dunk2k dunk2k deleted the comm_layout_adopt branch April 12, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft Awaiting requested review from noroadsleft

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dunk2k @fauxpark @noroadsleft @tzarc @JohnAZoidberg