backlight breathing overhaul #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently having trouble with the meira board by @colemarkham. He seems to have a pretty unusual setup for backlight and breathing. For example, in rules.mk, he has I hope he can look over this and either bring his files more in line with other keyboards or tell me how his implementation is supposed to work. |
BalzGuenat
commented
Dec 21, 2017
| @@ -127,7 +127,7 @@ https://github.com/tekezo/Karabiner/issues/403 | |||
|
|
|||
| ## Esc and <code>`</code> on a Single Key | |||
|
|
|||
| See the [Grave Escape](feature_grave_escape.md) feature. | |||
| See the [Grave Escape](feature_grave_esc.md) feature. | |||
There was a problem hiding this comment.
This has nothing to do with the rest but I put in the fix anyway,
|
These things should also fix the issues described here: #1415 |
… to reach true max brightness
|
This is awesome :) thanks! |
raymond-w-ko
pushed a commit
to raymond-w-ko/qmk_firmware
that referenced
this pull request
Jan 3, 2018
* add breathing to bananasplit * backlight breathing overhaul * fix the backlight_tick thing. * fix for vision_division backlight * fix a few keymaps and probably break breathing for some weirdly set-up boards. * remove BL_x keycodes because they made unreasonable assumptions * some fixes for BL keycodes * integer cie lightness scaling * use cie lightness for non-breathing backlight and make breathing able to reach true max brightness
LovesTha
pushed a commit
to LovesTha/qmk_firmware
that referenced
this pull request
Jul 24, 2018
* add breathing to bananasplit * backlight breathing overhaul * fix the backlight_tick thing. * fix for vision_division backlight * fix a few keymaps and probably break breathing for some weirdly set-up boards. * remove BL_x keycodes because they made unreasonable assumptions * some fixes for BL keycodes * integer cie lightness scaling * use cie lightness for non-breathing backlight and make breathing able to reach true max brightness
This was referenced Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor of the breathing code that also fixes #2181.