ADD keyboard Projectd/65/Projectd_65_ iso #21941

gskygithub · 2023-09-07T02:19:51Z

Description

ADD project_65_iso keyboard

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

github-actions · 2024-02-28T01:48:00Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

gskygithub · 2024-02-29T06:05:15Z

@fauxpark , could you please take a look at this PR, thanks.

fauxpark · 2024-02-29T06:10:42Z

keyboards/projectd/65/projectd_65_iso/config.h

+#define AW20216S_EN_PIN_1 C13
+#define AW20216S_EN_PIN_2 C13


Suggested change

#define AW20216S_EN_PIN_1 C13

#define AW20216S_EN_PIN_2 C13

#define AW20216S_EN_PIN C13

fauxpark · 2024-02-29T06:11:29Z

keyboards/projectd/65/projectd_65_iso/projectd_65_iso.c

+        setPinInput(SPI_SCK_PIN);
+        setPinInput(SPI_MOSI_PIN);
+        setPinInput(SPI_MISO_PIN);


Suggested change

setPinInput(SPI_SCK_PIN);

setPinInput(SPI_MOSI_PIN);

setPinInput(SPI_MISO_PIN);

gpio_set_pin_input(SPI_SCK_PIN);

gpio_set_pin_input(SPI_MOSI_PIN);

gpio_set_pin_input(SPI_MISO_PIN);

fauxpark · 2024-02-29T06:12:11Z

keyboards/projectd/65/projectd_65_iso/info.json

Please run qmk format-json -i on this file.

This is still outstanding.

Still outstanding, and this file can also be renamed to keyboard.json.

fauxpark · 2024-02-29T06:13:09Z

keyboards/projectd/65/projectd_65_iso/projectd_65_iso.c

+ *   |     |          |          | */
+    //{0, CS1_SW4,   CS2_SW4,   CS3_SW4},   //   0, Esc
+
+    {0, CS1_SW1,   CS2_SW1,   CS3_SW1},   //  0, Esc


These should be swapped around (SW1_CS1 etc).

waffle87 · 2024-03-30T18:04:09Z

keyboards/projectd/65/projectd_65_iso/keymaps/default/config.h

This file should be removed. If these definitions are needed, they can be moved to the keyboard level info.json file.

waffle87 · 2024-03-30T18:05:24Z

keyboards/projectd/65/projectd_65_iso/readme.md

@@ -0,0 +1,25 @@
+# ProjectD 65% ISO 
+![ProjectD 65 ISO](https://imgur.com/2LCEGnJh.png)


Suggested change

![ProjectD 65 ISO](https://imgur.com/2LCEGnJh.png)

![ProjectD 65 ISO](https://imgur.com/2LCEGnJ.png)

github-actions · 2024-06-17T01:53:42Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

fauxpark · 2024-06-17T03:37:03Z

keyboards/projectd/65/projectd_65_iso/rules.mk

This file can be deleted.

fauxpark · 2024-06-17T03:39:00Z

keyboards/projectd/65/projectd_65_iso/info.json

Still outstanding, and this file can also be renamed to keyboard.json.

fauxpark · 2024-06-17T06:00:40Z

keyboards/projectd/65/projectd_65_iso/keyboard.json

+            { "flags": 4, "matrix": [8, 4], "x": 137.5, "y": 10 },
+            { "flags": 4, "matrix": [7, 3], "x": 150, "y": 10 },
+            { "flags": 1, "matrix": [2, 1], "x": 0, "y": 20 },
+            { "flags": 4, "matrix": [1, 2], "x": 17.5, "y": 20 },
+            { "flags": 4, "matrix": [2, 2], "x": 27.5, "y": 20 },
+            { "flags": 4, "matrix": [3, 2], "x": 37.5, "y": 20 },
+            { "flags": 4, "matrix": [4, 2], "x": 47.5, "y": 20 },
+            { "flags": 4, "matrix": [4, 3], "x": 57.5, "y": 20 },
+            { "flags": 4, "matrix": [5, 3], "x": 67.5, "y": 20 },
+            { "flags": 4, "matrix": [5, 2], "x": 77.5, "y": 20 },
+            { "flags": 4, "matrix": [6, 2], "x": 87.5, "y": 20 },
+            { "flags": 4, "matrix": [7, 2], "x": 97.5, "y": 20 },
+            { "flags": 4, "matrix": [8, 2], "x": 107.5, "y": 20 },
+            { "flags": 4, "matrix": [8, 3], "x": 117.5, "y": 20 },
+            { "flags": 4, "matrix": [7, 5], "x": 127.5, "y": 20 },
+            { "flags": 4, "matrix": [2, 6], "x": 150, "y": 20 },
+            { "flags": 4, "matrix": [0, 0], "x": 0, "y": 30 },
+            { "flags": 4, "matrix": [0, 4], "x": 12.5, "y": 30 },
+            { "flags": 4, "matrix": [1, 4], "x": 22.5, "y": 30 },
+            { "flags": 4, "matrix": [2, 4], "x": 32.5, "y": 30 },
+            { "flags": 4, "matrix": [3, 4], "x": 42.5, "y": 30 },
+            { "flags": 4, "matrix": [4, 4], "x": 52.5, "y": 30 },
+            { "flags": 4, "matrix": [4, 5], "x": 62.5, "y": 30 },
+            { "flags": 4, "matrix": [5, 5], "x": 72.5, "y": 30 },
+            { "flags": 4, "matrix": [5, 4], "x": 82.5, "y": 30 },
+            { "flags": 4, "matrix": [6, 4], "x": 92.5, "y": 30 },
+            { "flags": 4, "matrix": [7, 4], "x": 102.5, "y": 30 },
+            { "flags": 4, "matrix": [8, 5], "x": 112.5, "y": 30 },
+            { "flags": 4, "matrix": [0, 7], "x": 122.5, "y": 30 },
+            { "flags": 4, "matrix": [1, 6], "x": 140, "y": 30 },
+            { "flags": 4, "matrix": [6, 3], "x": 150, "y": 30 },
+            { "flags": 4, "matrix": [0, 6], "x": 0, "y": 40 },
+            { "flags": 4, "matrix": [0, 5], "x": 12.5, "y": 40 },
+            { "flags": 4, "matrix": [0, 2], "x": 25, "y": 40 },
+            { "flags": 4, "x": 61.5, "y": 40 },
+            { "flags": 4, "x": 62.5, "y": 40 },
+            { "flags": 4, "matrix": [0, 1], "x": 65, "y": 40 },
+            { "flags": 4, "x": 67.5, "y": 40 },
+            { "flags": 4, "x": 68.5, "y": 40 },
+            { "flags": 4, "matrix": [3, 6], "x": 100, "y": 40 },
+            { "flags": 4, "matrix": [3, 3], "x": 112.5, "y": 40 },


Suggested change

{ "flags": 4, "matrix": [8, 4], "x": 137.5, "y": 10 },

{ "flags": 4, "matrix": [7, 3], "x": 150, "y": 10 },

{ "flags": 1, "matrix": [2, 1], "x": 0, "y": 20 },

{ "flags": 4, "matrix": [1, 2], "x": 17.5, "y": 20 },

{ "flags": 4, "matrix": [2, 2], "x": 27.5, "y": 20 },

{ "flags": 4, "matrix": [3, 2], "x": 37.5, "y": 20 },

{ "flags": 4, "matrix": [4, 2], "x": 47.5, "y": 20 },

{ "flags": 4, "matrix": [4, 3], "x": 57.5, "y": 20 },

{ "flags": 4, "matrix": [5, 3], "x": 67.5, "y": 20 },

{ "flags": 4, "matrix": [5, 2], "x": 77.5, "y": 20 },

{ "flags": 4, "matrix": [6, 2], "x": 87.5, "y": 20 },

{ "flags": 4, "matrix": [7, 2], "x": 97.5, "y": 20 },

{ "flags": 4, "matrix": [8, 2], "x": 107.5, "y": 20 },

{ "flags": 4, "matrix": [8, 3], "x": 117.5, "y": 20 },

{ "flags": 4, "matrix": [7, 5], "x": 127.5, "y": 20 },

{ "flags": 4, "matrix": [2, 6], "x": 150, "y": 20 },

{ "flags": 4, "matrix": [0, 0], "x": 0, "y": 30 },

{ "flags": 4, "matrix": [0, 4], "x": 12.5, "y": 30 },

{ "flags": 4, "matrix": [1, 4], "x": 22.5, "y": 30 },

{ "flags": 4, "matrix": [2, 4], "x": 32.5, "y": 30 },

{ "flags": 4, "matrix": [3, 4], "x": 42.5, "y": 30 },

{ "flags": 4, "matrix": [4, 4], "x": 52.5, "y": 30 },

{ "flags": 4, "matrix": [4, 5], "x": 62.5, "y": 30 },

{ "flags": 4, "matrix": [5, 5], "x": 72.5, "y": 30 },

{ "flags": 4, "matrix": [5, 4], "x": 82.5, "y": 30 },

{ "flags": 4, "matrix": [6, 4], "x": 92.5, "y": 30 },

{ "flags": 4, "matrix": [7, 4], "x": 102.5, "y": 30 },

{ "flags": 4, "matrix": [8, 5], "x": 112.5, "y": 30 },

{ "flags": 4, "matrix": [0, 7], "x": 122.5, "y": 30 },

{ "flags": 4, "matrix": [1, 6], "x": 140, "y": 30 },

{ "flags": 4, "matrix": [6, 3], "x": 150, "y": 30 },

{ "flags": 4, "matrix": [0, 6], "x": 0, "y": 40 },

{ "flags": 4, "matrix": [0, 5], "x": 12.5, "y": 40 },

{ "flags": 4, "matrix": [0, 2], "x": 25, "y": 40 },

{ "flags": 4, "x": 61.5, "y": 40 },

{ "flags": 4, "x": 62.5, "y": 40 },

{ "flags": 4, "matrix": [0, 1], "x": 65, "y": 40 },

{ "flags": 4, "x": 67.5, "y": 40 },

{ "flags": 4, "x": 68.5, "y": 40 },

{ "flags": 4, "matrix": [3, 6], "x": 100, "y": 40 },

{ "flags": 4, "matrix": [3, 3], "x": 112.5, "y": 40 },

{ "flags": 4, "matrix": [8, 4], "x": 137, "y": 10 },

{ "flags": 4, "matrix": [7, 3], "x": 150, "y": 10 },

{ "flags": 1, "matrix": [2, 1], "x": 0, "y": 20 },

{ "flags": 4, "matrix": [1, 2], "x": 17, "y": 20 },

{ "flags": 4, "matrix": [2, 2], "x": 27, "y": 20 },

{ "flags": 4, "matrix": [3, 2], "x": 37, "y": 20 },

{ "flags": 4, "matrix": [4, 2], "x": 47, "y": 20 },

{ "flags": 4, "matrix": [4, 3], "x": 57, "y": 20 },

{ "flags": 4, "matrix": [5, 3], "x": 67, "y": 20 },

{ "flags": 4, "matrix": [5, 2], "x": 77, "y": 20 },

{ "flags": 4, "matrix": [6, 2], "x": 87, "y": 20 },

{ "flags": 4, "matrix": [7, 2], "x": 97, "y": 20 },

{ "flags": 4, "matrix": [8, 2], "x": 107, "y": 20 },

{ "flags": 4, "matrix": [8, 3], "x": 117, "y": 20 },

{ "flags": 4, "matrix": [7, 5], "x": 127, "y": 20 },

{ "flags": 4, "matrix": [2, 6], "x": 150, "y": 20 },

{ "flags": 4, "matrix": [0, 0], "x": 0, "y": 30 },

{ "flags": 4, "matrix": [0, 4], "x": 12, "y": 30 },

{ "flags": 4, "matrix": [1, 4], "x": 22, "y": 30 },

{ "flags": 4, "matrix": [2, 4], "x": 32, "y": 30 },

{ "flags": 4, "matrix": [3, 4], "x": 42, "y": 30 },

{ "flags": 4, "matrix": [4, 4], "x": 52, "y": 30 },

{ "flags": 4, "matrix": [4, 5], "x": 62, "y": 30 },

{ "flags": 4, "matrix": [5, 5], "x": 72, "y": 30 },

{ "flags": 4, "matrix": [5, 4], "x": 82, "y": 30 },

{ "flags": 4, "matrix": [6, 4], "x": 92, "y": 30 },

{ "flags": 4, "matrix": [7, 4], "x": 102, "y": 30 },

{ "flags": 4, "matrix": [8, 5], "x": 112, "y": 30 },

{ "flags": 4, "matrix": [0, 7], "x": 122, "y": 30 },

{ "flags": 4, "matrix": [1, 6], "x": 140, "y": 30 },

{ "flags": 4, "matrix": [6, 3], "x": 150, "y": 30 },

{ "flags": 4, "matrix": [0, 6], "x": 0, "y": 40 },

{ "flags": 4, "matrix": [0, 5], "x": 12, "y": 40 },

{ "flags": 4, "matrix": [0, 2], "x": 25, "y": 40 },

{ "flags": 4, "x": 61, "y": 40 },

{ "flags": 4, "x": 62, "y": 40 },

{ "flags": 4, "matrix": [0, 1], "x": 65, "y": 40 },

{ "flags": 4, "x": 67, "y": 40 },

{ "flags": 4, "x": 68, "y": 40 },

{ "flags": 4, "matrix": [3, 6], "x": 100, "y": 40 },

{ "flags": 4, "matrix": [3, 3], "x": 112, "y": 40 },

keyboards/projectd/65/projectd_65_iso/keyboard.json

Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>

gskygithub added 30 commits June 7, 2022 09:19

Add files via upload

d9588c0

[keyboard]

8c7aff1

[Keyboard]

1dd4c87

Delete flash_spi.c

74e52d3

Delete flash_spi.h

19b7d38

Delete wb32_spi_master.c

7f77d7a

Delete wb32_spi_master.h

2c0fe84

[Keyboard]

ecbff72

Resolved requested changes

9c423d1

Resolved requested changes

318c463

Changed rules.mk file accordingly.

dd42220

Resolved changes accordingly.

52a3301

Update config.h file and rules.mk file

1c3f1e6

Removed eeprom_flash.c file

8db03c1

Update default/keymap.c file

6b050ac

Delete keyboards/darkproject/kd83a_bfg_edition directory

03ff34c

Add keyboard

da0a8e5

Merge branch 'qmk:master' into master

733cf2c

Add keyboard

273d1da

Delete darkproject/kd83a_bfg_edition directory

4f3f6c9

Resolved Changes

4773980

Merge branch 'qmk:master' into master

ded388f

Resolved requested changes

e79a657

Merge branch 'qmk:master' into master

5fedd8a

keyboard

c89ae6b

Add keyboard

45d803f

Delete keyboard

11e36a3

Merge branch 'qmk:master' into master

1dce29e

Merge branch 'qmk:master' into master

71157f0

Add keyboard

5d9043d

drashna requested a review from a team January 13, 2024 06:50

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Feb 28, 2024

fauxpark requested changes Feb 29, 2024

View reviewed changes

github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Mar 1, 2024

gskygithub added 2 commits March 1, 2024 09:57

Merge branch 'qmk:master' into projectd_65_iso

f36309a

Resolved requested changes

a48bf5f

gskygithub requested a review from fauxpark March 1, 2024 01:59

waffle87 requested changes Mar 30, 2024

View reviewed changes

gskygithub added 3 commits April 3, 2024 16:10

Merge branch 'qmk:master' into projectd_65_iso

f06f9f5

Delete keyboards/projectd/65/projectd_65_iso/keymaps/default/config.h

90cd00c

Resolved requested changes

c744797

gskygithub requested a review from waffle87 April 3, 2024 08:13

Merge branch 'qmk:master' into projectd_65_iso

d2c81e4

drashna requested a review from a team May 2, 2024 22:37

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 17, 2024

fauxpark requested changes Jun 17, 2024

View reviewed changes

gskygithub added 2 commits June 17, 2024 13:55

Merge branch 'qmk:master' into projectd_65_iso

c41e91c

Rename info.json to keyboard.json

91ff4fe

fauxpark requested changes Jun 17, 2024

View reviewed changes

gskygithub added 2 commits June 17, 2024 14:01

Delete keyboards/projectd/65/projectd_65_iso/rules.mk

46657a3

Update keyboard.json

f53fbd8

github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jun 18, 2024

gskygithub requested a review from fauxpark June 19, 2024 01:57

fauxpark approved these changes Jun 19, 2024

View reviewed changes

dunk2k suggested changes Jun 19, 2024

View reviewed changes

keyboards/projectd/65/projectd_65_iso/keyboard.json Outdated Show resolved Hide resolved

Update keyboards/projectd/65/projectd_65_iso/keyboard.json

a87214e

Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>

dunk2k approved these changes Jun 19, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ADD keyboard Projectd/65/Projectd_65_ iso #21941

ADD keyboard Projectd/65/Projectd_65_ iso #21941

gskygithub commented Sep 7, 2023

github-actions bot commented Feb 28, 2024

gskygithub commented Feb 29, 2024

fauxpark Feb 29, 2024

fauxpark Feb 29, 2024

fauxpark Feb 29, 2024

fauxpark May 2, 2024

fauxpark Jun 17, 2024

fauxpark Feb 29, 2024

waffle87 Mar 30, 2024

waffle87 Mar 30, 2024

github-actions bot commented Jun 17, 2024

fauxpark Jun 17, 2024

fauxpark Jun 17, 2024

fauxpark Jun 17, 2024

	#define AW20216S_EN_PIN_1 C13
	#define AW20216S_EN_PIN_2 C13
	#define AW20216S_EN_PIN C13

		@@ -0,0 +1,25 @@
		# ProjectD 65% ISO
		![ProjectD 65 ISO](https://imgur.com/2LCEGnJh.png)

ADD keyboard Projectd/65/Projectd_65_ iso #21941

Are you sure you want to change the base?

ADD keyboard Projectd/65/Projectd_65_ iso #21941

Conversation

gskygithub commented Sep 7, 2023

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

github-actions bot commented Feb 28, 2024

gskygithub commented Feb 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jun 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment