Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Community Layouts for LAYOUT_(ansi|iso|default) keyboards #21984

Closed
wants to merge 53 commits into from

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Sep 12, 2023

Description

Assign matching Community Layout(s) to keyboards with LAYOUT_(ansi|iso|default) macro

  • where applicable; utilise layout_aliases to match layout name to Community Layout name
    • in keymaps, change layout macro names to match added Community Layout
  • add matrix_diagram.md where accurate information available

Keyboard Specific

  • ghs/jem:
    • move ISO layouts into soldered sub-directory, as hotswap_ansi doesn't support ISO layouts

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 12, 2023
@dunk2k dunk2k marked this pull request as ready for review September 12, 2023 19:40
@dunk2k dunk2k changed the title amend community layout(s) for LAYOUT_(ansi|iso) boards amend community layout(s) for LAYOUT_(ansi|iso|default) boards Oct 5, 2023
@dunk2k dunk2k changed the title amend community layout(s) for LAYOUT_(ansi|iso|default) boards amend community layouts for LAYOUT_(ansi|iso|default) boards Dec 1, 2023
@dunk2k dunk2k changed the base branch from develop to master March 14, 2024 23:04
@dunk2k dunk2k changed the base branch from master to develop March 19, 2024 16:26
@dunk2k dunk2k changed the title amend community layouts for LAYOUT_(ansi|iso|default) boards add Community Layouts for LAYOUT_(ansi|iso|default) keyboards Apr 12, 2024
@dunk2k
Copy link
Contributor Author

dunk2k commented Apr 12, 2024

this PR segmented alphabetically into smaller PRs

@dunk2k dunk2k closed this Apr 12, 2024
@dunk2k dunk2k deleted the comm_layout_other branch April 12, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants