Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support Nyx Rev.2 soldering #22047

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added support Nyx Rev.2 soldering #22047

wants to merge 2 commits into from
+990 −0

Conversation

HorrorTroll
Copy link
Contributor

Description

Added support Nyx Rev.2 soldering.
This PR need to be waiting for #21143 merged first.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 16, 2023
@HorrorTroll HorrorTroll marked this pull request as draft September 16, 2023 09:50
@drashna drashna added the awaiting_pr Relies on another PR to be merged first label Sep 19, 2023
@drashna drashna requested a review from a team September 19, 2023 01:16
@HorrorTroll HorrorTroll marked this pull request as ready for review October 31, 2023 04:20
@HorrorTroll
Copy link
Contributor Author

Ready for reviewing now

@drashna drashna removed the awaiting_pr Relies on another PR to be merged first label Nov 8, 2023
@drashna drashna requested a review from a team November 8, 2023 06:36
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 24, 2023
@drashna drashna removed the stale Issues or pull requests that have become inactive without resolution. label Jan 13, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Feb 28, 2024
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Feb 29, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Apr 24, 2024
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Apr 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 9, 2024
fauxpark
fauxpark requested changes Jun 11, 2024
View reviewed changes
keyboards/horrortroll/nyx/rev2/solder/rules.mk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be deleted.

keyboards/horrortroll/nyx/rev2/solder/info.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be renamed to keyboard.json.

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HorrorTroll @drashna @fauxpark