Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First SPV1 support #22140

Closed
wants to merge 13 commits into from
Closed

First SPV1 support #22140

wants to merge 13 commits into from

Conversation

Gondolindrim
Copy link
Contributor

Description

Adds support for Bisoromi's SPV1 keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 26, 2023
@Gondolindrim Gondolindrim marked this pull request as ready for review September 26, 2023 02:57
drashna
drashna requested changes Sep 26, 2023
View reviewed changes
keyboards/spv1/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/spv1/rules.mk Outdated Show resolved Hide resolved
drashna
drashna requested changes Sep 26, 2023
View reviewed changes
keyboards/spv1/keymaps/via/keymap.c Outdated Show resolved Hide resolved
Gondolindrim and others added 3 commits September 26, 2023 14:33
@Gondolindrim @drashna
Change RESET to QK_BOOT
82d504e 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@Gondolindrim @drashna
Remove rules.mk
76f3412 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@Gondolindrim @drashna
Update keyboards/spv1/keymaps/via/keymap.c
b9f5bd1 
Co-authored-by: Drashna Jaelre <drashna@live.com>
drashna
drashna reviewed Sep 29, 2023
View reviewed changes
keyboards/spv1/readme.md Outdated Show resolved Hide resolved
keyboards/spv1/spv1.c Outdated Show resolved Hide resolved
@Gondolindrim @drashna
Change image link to raw
fc41619 
Co-authored-by: Drashna Jaelre <drashna@live.com>
drashna
drashna reviewed Oct 5, 2023
View reviewed changes
keyboards/spv1/spv1.c Outdated Show resolved Hide resolved
dunk2k
dunk2k suggested changes Oct 5, 2023
View reviewed changes
keyboards/spv1/readme.md Outdated Show resolved Hide resolved
dunk2k
dunk2k suggested changes Oct 5, 2023
View reviewed changes
keyboards/spv1/rules.mk Outdated Show resolved Hide resolved
keyboards/spv1/info.json Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Nov 26, 2023
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Dec 2, 2023
drashna
drashna reviewed Dec 5, 2023
View reviewed changes
keyboards/spv1/info.json Outdated Show resolved Hide resolved
Gondolindrim and others added 2 commits December 5, 2023 23:54
@Gondolindrim @waffle87
Add user func callback
1d4781a 
Co-authored-by: jack <0x6a73@protonmail.com>
@Gondolindrim
Add alternative numpad layouts; change default and via keymaps for th…
64b5dc7 
…e `LAYOUT_all` version
@drashna drashna requested a review from a team December 14, 2023 00:23
zvecr
zvecr requested changes Dec 14, 2023
View reviewed changes
keyboards/spv1/config.h
Comment on lines +32 to +34

#define WEAR_LEVELING_LOGICAL_SIZE 2048
#define WEAR_LEVELING_BACKING_SIZE 4096
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define WEAR_LEVELING_LOGICAL_SIZE 2048
#define WEAR_LEVELING_BACKING_SIZE 4096

keyboards/spv1/info.json
Comment on lines +28 to +29
},
"diode_direction": "COL2ROW",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
},
"diode_direction": "COL2ROW",
},
"eeprom": {
"wear_leveling": {
"backing_size": 4096
}
},
"diode_direction": "COL2ROW",

fauxpark
fauxpark reviewed Dec 14, 2023
View reviewed changes
keyboards/spv1/info.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run qmk format-json -i on this file after all other review suggestions.

@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jan 29, 2024
@drashna drashna added awaiting review and removed stale Issues or pull requests that have become inactive without resolution. labels Feb 1, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Aug 24, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark left review comments

@waffle87 waffle87 waffle87 left review comments

@zvecr zvecr zvecr requested changes

@dunk2k dunk2k dunk2k requested changes

Assignees
No one assigned
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution. via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Gondolindrim @drashna @fauxpark @zvecr @waffle87 @dunk2k