Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD keyboard vortex/M0110 #22182

Closed
wants to merge 113 commits into from
Closed

ADD keyboard vortex/M0110 #22182

wants to merge 113 commits into from

Conversation

gskygithub
Copy link
Contributor

Description

Add m0110 keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jan 12, 2024
@drashna drashna requested review from a team and removed request for dunk2k January 14, 2024 16:42
keyboards/vortex/m0110/keymaps/default/config.h Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run qmk format-json -i on this file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still outstanding.

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jan 15, 2024

/* External spi flash */
#define EXTERNAL_FLASH_SPI_SLAVE_SELECT_PIN B14
#define WEAR_LEVELING_BACKING_SIZE (8 * 1024)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define WEAR_LEVELING_BACKING_SIZE (8 * 1024)

@@ -0,0 +1 @@
WEAR_LEVELING_DRIVER = spi_flash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
WEAR_LEVELING_DRIVER = spi_flash
# This file intentionally left blank

Comment on lines 19 to 25
## Bootloader
Enter the bootloader in 3 ways:
* **Bootmagic reset**: Hold down the key at (1,6) in the matrix, top left key/Escape, and plug in the keyboard
* **Physical reset button**: Hold the Reset switch mounted on the surface of the PCB's rear side after the USB cable is connected
* **Fn+Tab**: Press the key will reset the board to bootloader mode

See the [build environment setup](https://docs.qmk.fm/#/getting_started_build_tools) and the [make instructions](https://docs.qmk.fm/#/getting_started_make_guide) for more information. Brand new to QMK? Start with our [Complete Newbs Guide](https://docs.qmk.fm/#/newbs).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Bootloader
Enter the bootloader in 3 ways:
* **Bootmagic reset**: Hold down the key at (1,6) in the matrix, top left key/Escape, and plug in the keyboard
* **Physical reset button**: Hold the Reset switch mounted on the surface of the PCB's rear side after the USB cable is connected
* **Fn+Tab**: Press the key will reset the board to bootloader mode
See the [build environment setup](https://docs.qmk.fm/#/getting_started_build_tools) and the [make instructions](https://docs.qmk.fm/#/getting_started_make_guide) for more information. Brand new to QMK? Start with our [Complete Newbs Guide](https://docs.qmk.fm/#/newbs).
See the [build environment setup](https://docs.qmk.fm/#/getting_started_build_tools) and the [make instructions](https://docs.qmk.fm/#/getting_started_make_guide) for more information. Brand new to QMK? Start with our [Complete Newbs Guide](https://docs.qmk.fm/#/newbs).
## Bootloader
Enter the bootloader in 3 ways:
* **Bootmagic reset**: Hold down the key at (1,6) in the matrix, top left key/Escape, and plug in the keyboard
* **Physical reset button**: Hold the Reset switch mounted on the surface of the PCB's rear side after the USB cable is connected
* **Fn+Tab**: Press the key will reset the board to bootloader mode

"vid": "0x342D"
},
"eeprom": {
"driver": "wear_leveling"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"driver": "wear_leveling"
"driver": "wear_leveling",
"wear_leveling": {
"driver": "spi_flash",
"backing_size": 8192
}

},
"diode_direction": "COL2ROW",
"features": {
"audio": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"audio": false,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesnt add value and should be removed, as it duplicates config that is at the keyboard level.

@gskygithub gskygithub requested a review from zvecr January 22, 2024 08:53
Copy link

github-actions bot commented Mar 8, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Mar 8, 2024
@gskygithub
Copy link
Contributor Author

@fauxpark @noroadsleft @zvecr can some one please take a look at this PR, thanks

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Mar 9, 2024
Comment on lines 19 to 23
/* Mechanical locking support. Use KC_LCAP, KC_LNUM or KC_LSCR instead in keymap */
#define LOCKING_SUPPORT_ENABLE
/* Locking resynchronize hack */
#define LOCKING_RESYNC_ENABLE

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* Mechanical locking support. Use KC_LCAP, KC_LNUM or KC_LSCR instead in keymap */
#define LOCKING_SUPPORT_ENABLE
/* Locking resynchronize hack */
#define LOCKING_RESYNC_ENABLE

},
"processor": "WB32FQ95",
"qmk": {
"tap_keycode_delay": 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"tap_keycode_delay": 10
"tap_keycode_delay": 10,
"locking": {
"enabled": true,
"resync": true
}

Comment on lines 2 to 3
![m0110](https://imgur.com/Of6i8EAh.png)
![m0110](https://imgur.com/gTac6uuh.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![m0110](https://imgur.com/Of6i8EAh.png)
![m0110](https://imgur.com/gTac6uuh.png)
![m0110](https://imgur.com/Of6i8EA.png)
![m0110](https://imgur.com/gTac6uu.png)

@gskygithub gskygithub requested a review from waffle87 April 3, 2024 08:12
Comment on lines +49 to +118
{ "label": "\\", "matrix": [10, 2], "w": 1.5, "x": 13.5, "y": 0 },

{ "label": "ESC", "matrix": [1, 6], "x": 0, "y": 1 },
{ "label": "1", "matrix": [1, 7], "x": 1, "y": 1 },
{ "label": "2", "matrix": [2, 7], "x": 2, "y": 1 },
{ "label": "3", "matrix": [3, 7], "x": 3, "y": 1 },
{ "label": "4", "matrix": [4, 7], "x": 4, "y": 1 },
{ "label": "5", "matrix": [4, 6], "x": 5, "y": 1 },
{ "label": "6", "matrix": [5, 6], "x": 6, "y": 1 },
{ "label": "7", "matrix": [5, 7], "x": 7, "y": 1 },
{ "label": "8", "matrix": [6, 7], "x": 8, "y": 1 },
{ "label": "9", "matrix": [7, 7], "x": 9, "y": 1 },
{ "label": "0", "matrix": [8, 7], "x": 10, "y": 1 },
{ "label": "-", "matrix": [8, 6], "x": 11, "y": 1 },
{ "label": "=", "matrix": [6, 6], "x": 12, "y": 1 },
{ "label": "Backspace", "matrix": [10, 1], "x": 13, "y": 1 },
{ "label": "del", "matrix": [6, 5], "x": 14, "y": 1 },

{ "label": "Tab", "matrix": [1, 1], "w": 1.5, "x": 0, "y": 2 },
{ "label": "Q", "matrix": [1, 0], "x": 1.5, "y": 2 },
{ "label": "W", "matrix": [2, 0], "x": 2.5, "y": 2 },
{ "label": "E", "matrix": [3, 0], "x": 3.5, "y": 2 },
{ "label": "R", "matrix": [4, 0], "x": 4.5, "y": 2 },
{ "label": "T", "matrix": [4, 1], "x": 5.5, "y": 2 },
{ "label": "Y", "matrix": [5, 1], "x": 6.5, "y": 2 },
{ "label": "U", "matrix": [5, 0], "x": 7.5, "y": 2 },
{ "label": "I", "matrix": [6, 0], "x": 8.5, "y": 2 },
{ "label": "O", "matrix": [7, 0], "x": 9.5, "y": 2 },
{ "label": "P", "matrix": [8, 0], "x": 10.5, "y": 2 },
{ "label": "[", "matrix": [8, 1], "x": 11.5, "y": 2 },
{ "label": "]", "matrix": [6, 1], "x": 12.5, "y": 2 },
{ "label": "\\", "matrix": [10, 5], "w": 1.5, "x": 13.5, "y": 2 },

{ "label": "Caps Lock", "matrix": [2, 1], "w": 1.75, "x": 0, "y": 3 },
{ "label": "A", "matrix": [1, 2], "x": 1.75, "y": 3 },
{ "label": "S", "matrix": [2, 2], "x": 2.75, "y": 3 },
{ "label": "D", "matrix": [3, 2], "x": 3.75, "y": 3 },
{ "label": "F", "matrix": [4, 2], "x": 4.75, "y": 3 },
{ "label": "G", "matrix": [4, 3], "x": 5.75, "y": 3 },
{ "label": "H", "matrix": [5, 3], "x": 6.75, "y": 3 },
{ "label": "J", "matrix": [5, 2], "x": 7.75, "y": 3 },
{ "label": "K", "matrix": [6, 2], "x": 8.75, "y": 3 },
{ "label": "L", "matrix": [7, 2], "x": 9.75, "y": 3 },
{ "label": ";", "matrix": [8, 2], "x": 10.75, "y": 3 },
{ "label": "'", "matrix": [8, 3], "x": 11.75, "y": 3 },
{ "label": "#", "matrix": [0, 2], "x": 12.75, "y": 3 },
{ "label": "Enter", "matrix": [10, 4], "w": 1.25, "x": 13.75, "y": 3 },

{ "label": "Shift", "matrix": [0, 0], "w": 1.25, "x": 0, "y": 4 },
{ "label": "\\", "matrix": [2, 3], "x": 1.25, "y": 4 },
{ "label": "Z", "matrix": [1, 4], "x": 2.25, "y": 4 },
{ "label": "X", "matrix": [2, 4], "x": 3.25, "y": 4 },
{ "label": "C", "matrix": [3, 4], "x": 4.25, "y": 4 },
{ "label": "V", "matrix": [4, 4], "x": 5.25, "y": 4 },
{ "label": "B", "matrix": [4, 5], "x": 6.25, "y": 4 },
{ "label": "N", "matrix": [5, 5], "x": 7.25, "y": 4 },
{ "label": "M", "matrix": [5, 4], "x": 8.25, "y": 4 },
{ "label": ",", "matrix": [6, 4], "x": 9.25, "y": 4 },
{ "label": ".", "matrix": [7, 4], "x": 10.25, "y": 4 },
{ "label": "/", "matrix": [8, 5], "x": 11.25, "y": 4 },
{ "label": "Shift", "matrix": [9, 1], "w": 2.75, "x": 12.25, "y": 4 },

{ "label": "Ctrl", "matrix": [0, 6], "w": 1.25, "x": 0, "y": 5 },
{ "label": "Win", "matrix": [9, 0], "w": 1.25, "x": 1.25, "y": 5 },
{ "label": "Alt", "matrix": [9, 3], "w": 1.25, "x": 2.5, "y": 5 },
{ "label": "Space", "matrix": [9, 4], "w": 6.25, "x": 3.75, "y": 5 },
{ "label": "RAlt", "matrix": [9, 5], "w": 1.25, "x": 10, "y": 5 },
{ "label": "RWin", "matrix": [8, 4], "w": 1.25, "x": 11.25, "y": 5 },
{ "label": "RCtrl", "matrix": [0, 4], "w": 1.25, "x": 12.5, "y": 5 },
{ "label": "FN", "matrix": [9, 2], "w": 1.25, "x": 13.75, "y": 5 }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moves the 2u/Split Backspace keys around to visually clarify which are which:

image

⚠️ Requires companion changes to both keymap.c files.

Suggested change
{ "label": "\\", "matrix": [10, 2], "w": 1.5, "x": 13.5, "y": 0 },
{ "label": "ESC", "matrix": [1, 6], "x": 0, "y": 1 },
{ "label": "1", "matrix": [1, 7], "x": 1, "y": 1 },
{ "label": "2", "matrix": [2, 7], "x": 2, "y": 1 },
{ "label": "3", "matrix": [3, 7], "x": 3, "y": 1 },
{ "label": "4", "matrix": [4, 7], "x": 4, "y": 1 },
{ "label": "5", "matrix": [4, 6], "x": 5, "y": 1 },
{ "label": "6", "matrix": [5, 6], "x": 6, "y": 1 },
{ "label": "7", "matrix": [5, 7], "x": 7, "y": 1 },
{ "label": "8", "matrix": [6, 7], "x": 8, "y": 1 },
{ "label": "9", "matrix": [7, 7], "x": 9, "y": 1 },
{ "label": "0", "matrix": [8, 7], "x": 10, "y": 1 },
{ "label": "-", "matrix": [8, 6], "x": 11, "y": 1 },
{ "label": "=", "matrix": [6, 6], "x": 12, "y": 1 },
{ "label": "Backspace", "matrix": [10, 1], "x": 13, "y": 1 },
{ "label": "del", "matrix": [6, 5], "x": 14, "y": 1 },
{ "label": "Tab", "matrix": [1, 1], "w": 1.5, "x": 0, "y": 2 },
{ "label": "Q", "matrix": [1, 0], "x": 1.5, "y": 2 },
{ "label": "W", "matrix": [2, 0], "x": 2.5, "y": 2 },
{ "label": "E", "matrix": [3, 0], "x": 3.5, "y": 2 },
{ "label": "R", "matrix": [4, 0], "x": 4.5, "y": 2 },
{ "label": "T", "matrix": [4, 1], "x": 5.5, "y": 2 },
{ "label": "Y", "matrix": [5, 1], "x": 6.5, "y": 2 },
{ "label": "U", "matrix": [5, 0], "x": 7.5, "y": 2 },
{ "label": "I", "matrix": [6, 0], "x": 8.5, "y": 2 },
{ "label": "O", "matrix": [7, 0], "x": 9.5, "y": 2 },
{ "label": "P", "matrix": [8, 0], "x": 10.5, "y": 2 },
{ "label": "[", "matrix": [8, 1], "x": 11.5, "y": 2 },
{ "label": "]", "matrix": [6, 1], "x": 12.5, "y": 2 },
{ "label": "\\", "matrix": [10, 5], "w": 1.5, "x": 13.5, "y": 2 },
{ "label": "Caps Lock", "matrix": [2, 1], "w": 1.75, "x": 0, "y": 3 },
{ "label": "A", "matrix": [1, 2], "x": 1.75, "y": 3 },
{ "label": "S", "matrix": [2, 2], "x": 2.75, "y": 3 },
{ "label": "D", "matrix": [3, 2], "x": 3.75, "y": 3 },
{ "label": "F", "matrix": [4, 2], "x": 4.75, "y": 3 },
{ "label": "G", "matrix": [4, 3], "x": 5.75, "y": 3 },
{ "label": "H", "matrix": [5, 3], "x": 6.75, "y": 3 },
{ "label": "J", "matrix": [5, 2], "x": 7.75, "y": 3 },
{ "label": "K", "matrix": [6, 2], "x": 8.75, "y": 3 },
{ "label": "L", "matrix": [7, 2], "x": 9.75, "y": 3 },
{ "label": ";", "matrix": [8, 2], "x": 10.75, "y": 3 },
{ "label": "'", "matrix": [8, 3], "x": 11.75, "y": 3 },
{ "label": "#", "matrix": [0, 2], "x": 12.75, "y": 3 },
{ "label": "Enter", "matrix": [10, 4], "w": 1.25, "x": 13.75, "y": 3 },
{ "label": "Shift", "matrix": [0, 0], "w": 1.25, "x": 0, "y": 4 },
{ "label": "\\", "matrix": [2, 3], "x": 1.25, "y": 4 },
{ "label": "Z", "matrix": [1, 4], "x": 2.25, "y": 4 },
{ "label": "X", "matrix": [2, 4], "x": 3.25, "y": 4 },
{ "label": "C", "matrix": [3, 4], "x": 4.25, "y": 4 },
{ "label": "V", "matrix": [4, 4], "x": 5.25, "y": 4 },
{ "label": "B", "matrix": [4, 5], "x": 6.25, "y": 4 },
{ "label": "N", "matrix": [5, 5], "x": 7.25, "y": 4 },
{ "label": "M", "matrix": [5, 4], "x": 8.25, "y": 4 },
{ "label": ",", "matrix": [6, 4], "x": 9.25, "y": 4 },
{ "label": ".", "matrix": [7, 4], "x": 10.25, "y": 4 },
{ "label": "/", "matrix": [8, 5], "x": 11.25, "y": 4 },
{ "label": "Shift", "matrix": [9, 1], "w": 2.75, "x": 12.25, "y": 4 },
{ "label": "Ctrl", "matrix": [0, 6], "w": 1.25, "x": 0, "y": 5 },
{ "label": "Win", "matrix": [9, 0], "w": 1.25, "x": 1.25, "y": 5 },
{ "label": "Alt", "matrix": [9, 3], "w": 1.25, "x": 2.5, "y": 5 },
{ "label": "Space", "matrix": [9, 4], "w": 6.25, "x": 3.75, "y": 5 },
{ "label": "RAlt", "matrix": [9, 5], "w": 1.25, "x": 10, "y": 5 },
{ "label": "RWin", "matrix": [8, 4], "w": 1.25, "x": 11.25, "y": 5 },
{ "label": "RCtrl", "matrix": [0, 4], "w": 1.25, "x": 12.5, "y": 5 },
{ "label": "FN", "matrix": [9, 2], "w": 1.25, "x": 13.75, "y": 5 }
{"label": "ESC", "matrix": [1, 6], "x": 0, "y": 0},
{"label": "1", "matrix": [1, 7], "x": 1, "y": 0},
{"label": "2", "matrix": [2, 7], "x": 2, "y": 0},
{"label": "3", "matrix": [3, 7], "x": 3, "y": 0},
{"label": "4", "matrix": [4, 7], "x": 4, "y": 0},
{"label": "5", "matrix": [4, 6], "x": 5, "y": 0},
{"label": "6", "matrix": [5, 6], "x": 6, "y": 0},
{"label": "7", "matrix": [5, 7], "x": 7, "y": 0},
{"label": "8", "matrix": [6, 7], "x": 8, "y": 0},
{"label": "9", "matrix": [7, 7], "x": 9, "y": 0},
{"label": "0", "matrix": [8, 7], "x": 10, "y": 0},
{"label": "-", "matrix": [8, 6], "x": 11, "y": 0},
{"label": "=", "matrix": [6, 6], "x": 12, "y": 0},
{"label": "\\", "matrix": [10, 2], "x": 13, "y": 0.5, "h": 0.5},
{"label": "Backspace", "matrix": [10, 1], "x": 13, "y": 0, "w": 2, "h": 0.5},
{"label": "del", "matrix": [6, 5], "x": 14, "y": 0.5, "h": 0.5},
{"label": "Tab", "matrix": [1, 1], "w": 1.5, "x": 0, "y": 1},
{"label": "Q", "matrix": [1, 0], "x": 1.5, "y": 1},
{"label": "W", "matrix": [2, 0], "x": 2.5, "y": 1},
{"label": "E", "matrix": [3, 0], "x": 3.5, "y": 1},
{"label": "R", "matrix": [4, 0], "x": 4.5, "y": 1},
{"label": "T", "matrix": [4, 1], "x": 5.5, "y": 1},
{"label": "Y", "matrix": [5, 1], "x": 6.5, "y": 1},
{"label": "U", "matrix": [5, 0], "x": 7.5, "y": 1},
{"label": "I", "matrix": [6, 0], "x": 8.5, "y": 1},
{"label": "O", "matrix": [7, 0], "x": 9.5, "y": 1},
{"label": "P", "matrix": [8, 0], "x": 10.5, "y": 1},
{"label": "[", "matrix": [8, 1], "x": 11.5, "y": 1},
{"label": "]", "matrix": [6, 1], "x": 12.5, "y": 1},
{"label": "\\", "matrix": [10, 5], "w": 1.5, "x": 13.5, "y": 1},
{"label": "Caps Lock", "matrix": [2, 1], "w": 1.75, "x": 0, "y": 2},
{"label": "A", "matrix": [1, 2], "x": 1.75, "y": 2},
{"label": "S", "matrix": [2, 2], "x": 2.75, "y": 2},
{"label": "D", "matrix": [3, 2], "x": 3.75, "y": 2},
{"label": "F", "matrix": [4, 2], "x": 4.75, "y": 2},
{"label": "G", "matrix": [4, 3], "x": 5.75, "y": 2},
{"label": "H", "matrix": [5, 3], "x": 6.75, "y": 2},
{"label": "J", "matrix": [5, 2], "x": 7.75, "y": 2},
{"label": "K", "matrix": [6, 2], "x": 8.75, "y": 2},
{"label": "L", "matrix": [7, 2], "x": 9.75, "y": 2},
{"label": ";", "matrix": [8, 2], "x": 10.75, "y": 2},
{"label": "'", "matrix": [8, 3], "x": 11.75, "y": 2},
{"label": "#", "matrix": [0, 2], "x": 12.75, "y": 2},
{"label": "Enter", "matrix": [10, 4], "w": 1.25, "x": 13.75, "y": 2},
{"label": "Shift", "matrix": [0, 0], "w": 1.25, "x": 0, "y": 3},
{"label": "\\", "matrix": [2, 3], "x": 1.25, "y": 3},
{"label": "Z", "matrix": [1, 4], "x": 2.25, "y": 3},
{"label": "X", "matrix": [2, 4], "x": 3.25, "y": 3},
{"label": "C", "matrix": [3, 4], "x": 4.25, "y": 3},
{"label": "V", "matrix": [4, 4], "x": 5.25, "y": 3},
{"label": "B", "matrix": [4, 5], "x": 6.25, "y": 3},
{"label": "N", "matrix": [5, 5], "x": 7.25, "y": 3},
{"label": "M", "matrix": [5, 4], "x": 8.25, "y": 3},
{"label": ",", "matrix": [6, 4], "x": 9.25, "y": 3},
{"label": ".", "matrix": [7, 4], "x": 10.25, "y": 3},
{"label": "/", "matrix": [8, 5], "x": 11.25, "y": 3},
{"label": "Shift", "matrix": [9, 1], "w": 2.75, "x": 12.25, "y": 3},
{"label": "Ctrl", "matrix": [0, 6], "w": 1.25, "x": 0, "y": 4},
{"label": "Win", "matrix": [9, 0], "w": 1.25, "x": 1.25, "y": 4},
{"label": "Alt", "matrix": [9, 3], "w": 1.25, "x": 2.5, "y": 4},
{"label": "Space", "matrix": [9, 4], "w": 6.25, "x": 3.75, "y": 4},
{"label": "RAlt", "matrix": [9, 5], "w": 1.25, "x": 10, "y": 4},
{"label": "RWin", "matrix": [8, 4], "w": 1.25, "x": 11.25, "y": 4},
{"label": "RCtrl", "matrix": [0, 4], "w": 1.25, "x": 12.5, "y": 4},
{"label": "FN", "matrix": [9, 2], "w": 1.25, "x": 13.75, "y": 4}

Comment on lines +26 to +27
KC_BSLS,
KC_ESC, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSPC, KC_DEL,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and the companion keymap.c changes:

Suggested change
KC_BSLS,
KC_ESC, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSPC, KC_DEL,
KC_ESC, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSLS, KC_BSPC, KC_DEL,

Comment on lines +26 to +27
KC_BSLS,
KC_ESC, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSPC, KC_DEL,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
KC_BSLS,
KC_ESC, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSPC, KC_DEL,
KC_ESC, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSLS, KC_BSPC, KC_DEL,

Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 16, 2024
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution. via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants