Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qmk find: Fix failure with multiple filters #22497

Merged
merged 1 commit into from
Nov 18, 2023

Commits on Nov 18, 2023

  1. qmk find: Fix failure with multiple filters

    When multiple `-f FILTER` options were specified, `qmk find` did not
    return anything at all instead of printing the list of entries that
    matched all of the specified filters.
    
    The problem was that the statement in `_filter_keymap_targets()` that
    filled `targets` had a wrong indent and therefore was executed for every
    filter instead of only once after applying all filters, and
    `valid_keymaps` was actually an iterator and therefore could be used
    only once.  Moving the statement outside of the loop fixes the problem.
    sigprof committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    538f26e View commit details
    Browse the repository at this point in the history