[Pointing] Add uart based SpaceMouse Module support #22519
Draft
+224
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
force-pushed
the
space_mouse_coast_to_coast
branch
from
9bb047f
to
0a9352d
Compare
keyboard-magpie
approved these changes
Nov 21, 2023
it's 3 axis, so it's not really a good comparison. But it wouldn't be hard to implement scrolling, both horizontal and vertical with the tilt or shift axis, and use the other for mouse movement. but would have to check both sets and filter out, since it is very easy to trigger both (ran into that in testing). However, I was mostly concerned with getting it working. And there is a provided way to customize how the reporting is translated, which I think is good enough for now. |
daskygit
requested changes
Nov 21, 2023
Comment on lines
+529
to
+530
| .set_cpi = NULL, | ||
| .get_cpi = NULL |
There was a problem hiding this comment.
It'd be nice to have some form of software scaling here.
drashna
force-pushed
the
space_mouse_coast_to_coast
branch
3 times, most recently
from
5587275
to
2c02433
Compare
Co-authored-by: Dasky <32983009+daskygit@users.noreply.github.com>
drashna
force-pushed
the
space_mouse_coast_to_coast
branch
from
63cc65f
to
ca6caeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Title.
Types of Changes
Issues Fixed or Closed by This PR
Checklist