Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LED drivers: extract IS31FL3745 from IS31COMMON #22636

Merged
merged 2 commits into from
Jan 1, 2024
Merged

LED drivers: extract IS31FL3745 from IS31COMMON #22636

merged 2 commits into from
Jan 1, 2024

Conversation

fauxpark
Copy link
Member

Description

#22635

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team December 10, 2023 08:22
@fauxpark fauxpark mentioned this pull request Dec 10, 2023
Merged
14 tasks
@drashna drashna requested a review from a team December 24, 2023 18:21
@fauxpark fauxpark merged commit a88dd67 into qmk:develop Jan 1, 2024
4 checks passed
@fauxpark fauxpark deleted the is31fl3745 branch January 1, 2024 08:31
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@fauxpark @itsjonny96
LED drivers: extract IS31FL3745 from IS31COMMON (qmk#22636)
8bcfc1b
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@fauxpark @mechlovin
LED drivers: extract IS31FL3745 from IS31COMMON (qmk#22636)
e6dd00d
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@fauxpark @mechlovin
LED drivers: extract IS31FL3745 from IS31COMMON (qmk#22636)
0cc77b4
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@fauxpark @nuess0r
LED drivers: extract IS31FL3745 from IS31COMMON (qmk#22636)
ecb4d54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @drashna