Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for mechlovin/olly/octagon #22796

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Temporary fix for mechlovin/olly/octagon #22796

merged 1 commit into from
Jan 1, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 1, 2024

Description

LED config is invalid, so count is not currently generated. Partial revert from 22792.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Jan 1, 2024
@zvecr zvecr merged commit 0ea3203 into develop Jan 1, 2024
3 checks passed
@zvecr zvecr deleted the zvecr-patch-1 branch January 1, 2024 02:40
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants