Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handwired/dactyl_manuform/5x6_68 - Fix layout macro #22950

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

handwired/dactyl_manuform/5x6_68 - Fix layout macro #22950

wants to merge 3 commits into from
+38 −38

Conversation

senchpimy
Copy link

@senchpimy senchpimy commented Jan 23, 2024 •
edited by zvecr
Loading

Description

A refactor broke the matrix in old keyboards, reverting the changes to the layout macro to match the old behaviour.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@keyboard-magpie
Copy link
Contributor

This is not an appropriate way to address this issue. If the refactor broke it, the actual info.json needs patched.

@zvecr zvecr changed the title Warning for old keyboards handwired/dactyl_manuform/5x6_68 - Fix layout macro Jan 23, 2024
@zvecr zvecr removed the invalid label Jan 23, 2024
@senchpimy
Copy link
Author

Ok, fixed

@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Mar 22, 2024
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Mar 31, 2024
@senchpimy senchpimy requested a review from drashna May 5, 2024 03:33
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keyboard stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@senchpimy @keyboard-magpie @drashna @zvecr