Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for the MMkeyboard Class60 #22972

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Added support for the MMkeyboard Class60 #22972

wants to merge 19 commits into from
+1,153 −0

Conversation

lexbrugman
Copy link
Contributor

Description

Added support for the MMkeyboard Class60 (only the soldered pcb as that's what I have to test with)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 27, 2024
@lexbrugman lexbrugman force-pushed the mmkeyboard-class60 branch 2 times, most recently from 4e09660 to 455432b Compare January 27, 2024 15:59
waffle87
waffle87 requested changes Jan 28, 2024
View reviewed changes
keyboards/mmkeyboard/class60/soldered/README.md Outdated Show resolved Hide resolved
keyboards/mmkeyboard/class60/soldered/config.h Outdated Show resolved Hide resolved
keyboards/mmkeyboard/class60/soldered/info.json Outdated Show resolved Hide resolved
keyboards/mmkeyboard/class60/soldered/config.h Outdated Show resolved Hide resolved
keyboards/mmkeyboard/class60/soldered/info.json Outdated Show resolved Hide resolved
keyboards/mmkeyboard/class60/soldered/rules.mk Outdated Show resolved Hide resolved
keyboards/mmkeyboard/class60/soldered/soldered.c Outdated Show resolved Hide resolved
keyboards/mmkeyboard/class60/soldered/soldered.c Outdated Show resolved Hide resolved
keyboards/mmkeyboard/class60/soldered/soldered.h Outdated Show resolved Hide resolved
keyboards/mmkeyboard/class60/soldered/info.json Outdated Show resolved Hide resolved
@lexbrugman lexbrugman force-pushed the mmkeyboard-class60 branch 2 times, most recently from f1e44be to 4ec1bb0 Compare February 23, 2024 17:16
@waffle87 waffle87 requested a review from a team February 23, 2024 20:53
@lexbrugman lexbrugman requested a review from drashna March 24, 2024 10:52
drashna
drashna requested changes Mar 29, 2024
View reviewed changes
keyboards/mmkeyboard/class60/soldered/config.h Outdated Show resolved Hide resolved
keyboards/mmkeyboard/class60/soldered/config.h Outdated Show resolved Hide resolved
keyboards/mmkeyboard/class60/soldered/config.h Outdated Show resolved Hide resolved
@lexbrugman lexbrugman requested a review from drashna April 15, 2024 18:50
dunk2k
dunk2k suggested changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add additional Community Layout support

keyboards/mmkeyboard/class60/soldered/info.json Outdated Show resolved Hide resolved
keyboards/mmkeyboard/class60/soldered/info.json Outdated Show resolved Hide resolved
@lexbrugman lexbrugman requested a review from dunk2k April 23, 2024 15:38
dunk2k
dunk2k suggested changes May 7, 2024
View reviewed changes
keyboards/mmkeyboard/class60/soldered/config.h Outdated Show resolved Hide resolved
keyboards/mmkeyboard/class60/soldered/info.json Outdated Show resolved Hide resolved
keyboards/mmkeyboard/class60/soldered/config.h Outdated Show resolved Hide resolved
keyboards/mmkeyboard/class60/soldered/info.json Outdated Show resolved Hide resolved
@lexbrugman lexbrugman requested a review from dunk2k May 9, 2024 18:00
@lexbrugman
Copy link
Contributor Author

@drashna what would be needed at this point to move this forward?

@lexbrugman lexbrugman requested a review from dunk2k June 9, 2024 11:17
@lexbrugman
Copy link
Contributor Author

Since there's two approvals now, who could merge this PR?

@dunk2k

This comment was marked as outdated.

Sign in to view
lexbrugman and others added 16 commits June 23, 2024 16:16
@lexbrugman
Added support for the MMkeyboard Class60
4938e1e
@lexbrugman
Move more Class60 config to data driven
42dd5d3
@lexbrugman
Addressed review comments for Class60 addition
a7a0dde
@lexbrugman
File header update in line with comments
ffcb6b4
@lexbrugman @waffle87
Apply suggestions from code review
63441cf 
Co-authored-by: jack <0x6a73@protonmail.com>
@lexbrugman
Switch to a new USB vid
7ae7c23
@lexbrugman @drashna
Apply suggestions from code review
acaab5e 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@lexbrugman
Remove mentioning of development board
fa31595
@lexbrugman @dunk2k
Apply suggestions from code review
cc3c3fe 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@lexbrugman
Fix linting issues
0fe4b72
@lexbrugman
Re-added community layout that was wrongly named
d22a1b9
@lexbrugman @dunk2k
Apply suggestions from code review
6bd0827 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@lexbrugman
Cleanup info.json
9a4f7d9
@lexbrugman
Rename info.json
0b27b36
@lexbrugman @dunk2k
Change ISO backslash to NUBS
06fd091 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@lexbrugman
Added default for Class60
5d5f512
zvecr
zvecr requested changes Jun 23, 2024
View reviewed changes
keyboards/mmkeyboard/class60/rules.mk Outdated Show resolved Hide resolved
keyboards/mmkeyboard/class60/soldered/chconf.h Outdated Show resolved Hide resolved
keyboards/mmkeyboard/class60/soldered/soldered.c Show resolved Hide resolved
@zvecr
Copy link
Member

zvecr commented Jun 23, 2024

Since there's two approvals now, who could merge this PR?

You require two green ticks from collabs, grey dont count.

@lexbrugman
Copy link
Contributor Author

Can file keyboards/mmkeyboard/class60/rules.mk be added with following contents?:

DEFAULT_FOLDER = mmkeyboard/class60/soldered

This ensures when compiling -kb mmkeyboard/class60 it gets from soldered directory instead of erroring.

Had added it, but removed again because of: #22972 (comment)

@lexbrugman @zvecr
Also update led state
6805d8d 
Co-authored-by: Joel Challis <git@zvecr.com>
@lexbrugman lexbrugman requested a review from zvecr June 23, 2024 15:42
@lexbrugman
Copy link
Contributor Author

lexbrugman commented Jul 6, 2024 •
edited
Loading

@zvecr let me know if any more changes are needed for your approval

@lesshonor lesshonor mentioned this pull request Jul 7, 2024
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k requested changes

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna Awaiting requested review from drashna

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lexbrugman @dunk2k @zvecr @drashna @waffle87