Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Skyloong/GK61 pro dual space keyboard. #22988

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Added Skyloong/GK61 pro dual space keyboard. #22988

wants to merge 15 commits into from
+790 −0

Conversation

NaturalZh
Copy link

GK61 pro double space keyboard

Description

The Skyloong GK61 PRO dual space key keyboard has two 3.125 split space bars. It can be replaced with a long space bar of 6.25.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 30, 2024
zvecr
zvecr requested changes Jan 30, 2024
View reviewed changes
keyboards/skyloong/gk61/pro_ds/config.h Outdated Show resolved Hide resolved
keyboards/skyloong/gk61/pro_ds/keymaps/default/rules.mk Outdated Show resolved Hide resolved
keyboards/skyloong/gk61/pro_ds/pro_ds.c Outdated Show resolved Hide resolved
keyboards/skyloong/gk61/pro_ds/pro_ds.c Outdated Show resolved Hide resolved
NaturalZh and others added 4 commits January 31, 2024 14:17
@NaturalZh @zvecr
Update keyboards/skyloong/gk61/pro_ds/config.h
5f43527 
OK, Thank you.

Co-authored-by: Joel Challis <git@zvecr.com>
@NaturalZh @zvecr
Update keyboards/skyloong/gk61/pro_ds/pro_ds.c
d48b24b 
OK.

Co-authored-by: Joel Challis <git@zvecr.com>
@NaturalZh @zvecr
Update keyboards/skyloong/gk61/pro_ds/pro_ds.c
f438b2f 
OK.

Co-authored-by: Joel Challis <git@zvecr.com>
@NaturalZh
deleted keyboards/skyloong/gk61/pro_ds/keymaps/default/rules.mk.
a62a526
zvecr
zvecr requested changes Jan 31, 2024
View reviewed changes
keyboards/skyloong/gk61/pro_ds/config.h Outdated Show resolved Hide resolved
keyboards/skyloong/gk61/pro_ds/info.json Outdated Show resolved Hide resolved
@NaturalZh NaturalZh requested a review from zvecr March 4, 2024 03:27
@NaturalZh
Copy link
Author

What else can I do about merging PR?

@drashna drashna requested a review from a team March 29, 2024 01:34
fauxpark
fauxpark requested changes Mar 29, 2024
View reviewed changes
keyboards/skyloong/gk61/pro_ds/config.h Outdated Show resolved Hide resolved
keyboards/skyloong/gk61/pro_ds/pro_ds.c Outdated Show resolved Hide resolved
keyboards/skyloong/gk61/pro_ds/pro_ds.c Outdated Show resolved Hide resolved
NaturalZh and others added 4 commits March 29, 2024 19:54
@NaturalZh @fauxpark
Update keyboards/skyloong/gk61/pro_ds/config.h
c654459 
OK. Thanks.

Co-authored-by: Ryan <fauxpark@gmail.com>
@NaturalZh @fauxpark
Update keyboards/skyloong/gk61/pro_ds/pro_ds.c
6d2b47b 
OK. Thanks.

Co-authored-by: Ryan <fauxpark@gmail.com>
@NaturalZh @fauxpark
Update keyboards/skyloong/gk61/pro_ds/pro_ds.c
0ef44f6 
OK, Thanks.

Co-authored-by: Ryan <fauxpark@gmail.com>
@NaturalZh
update skyloong/gk61/pro_ds/config.h
4f2e5d8
@NaturalZh
Copy link
Author

What can I do for this PR else ?

@qmk qmk deleted a comment from italovieira Apr 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 9, 2024
fauxpark
fauxpark requested changes Jun 11, 2024
View reviewed changes
keyboards/skyloong/gk61/pro_ds/pro_ds.c Outdated
* | | G location
* | | | B location
* | | | | */
{0, CS1_SW1, CS2_SW1, CS3_SW1},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SWx and CSx need to be swapped around eg. CS2_SW1 -> SW1_CS2.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I modified it. Please check again @fauxpark

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jun 12, 2024
@NaturalZh
Copy link
Author

Please review it again @fauxpark

@NaturalZh NaturalZh requested a review from fauxpark June 17, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr Awaiting requested review from zvecr

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NaturalZh @fauxpark @zvecr