Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[handwired/macroboard] Add rp2040 and update configuration #23022

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

[handwired/macroboard] Add rp2040 and update configuration #23022

wants to merge 10 commits into from
+50 −103

Conversation

Michal-Szczepaniak
Copy link

Updating my handwired/macroboard with rp2040 mcu option and moving stuff to info.json and general cleanup.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the via Adds via keymap and/or updates keyboard for via support label Feb 5, 2024
@Michal-Szczepaniak Michal-Szczepaniak changed the base branch from master to develop February 14, 2024 10:53
fauxpark
fauxpark requested changes Feb 14, 2024
View reviewed changes
keyboards/handwired/macroboard/f401/info.json Outdated Show resolved Hide resolved
keyboards/handwired/macroboard/f411/chconf.h Outdated Show resolved Hide resolved
keyboards/handwired/macroboard/f411/chconf.h Outdated Show resolved Hide resolved
keyboards/handwired/macroboard/f411/info.json Outdated Show resolved Hide resolved
keyboards/handwired/macroboard/rp2040/info.json Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Feb 14, 2024
View reviewed changes
keyboards/handwired/macroboard/f401/info.json Outdated Show resolved Hide resolved
keyboards/handwired/macroboard/f411/info.json Outdated Show resolved Hide resolved
keyboards/handwired/macroboard/info.json Outdated Show resolved Hide resolved
keyboards/handwired/macroboard/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/macroboard/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/macroboard/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/macroboard/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/macroboard/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/macroboard/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the via Adds via keymap and/or updates keyboard for via support label Feb 14, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Mar 31, 2024
@Michal-Szczepaniak Michal-Szczepaniak force-pushed the update-macroboard branch 2 times, most recently from 08cf720 to 249681b Compare March 31, 2024 09:30
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Apr 1, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label May 17, 2024
@Michal-Szczepaniak
Copy link
Author

one day this will be merged :D

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label May 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 2, 2024
fauxpark
fauxpark requested changes Jul 2, 2024
View reviewed changes
keyboards/handwired/macroboard/rp2040/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/macroboard/rp2040/info.json Outdated Show resolved Hide resolved
keyboards/handwired/macroboard/f411/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/macroboard/f411/info.json Outdated Show resolved Hide resolved
keyboards/handwired/macroboard/f401/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/macroboard/f401/info.json Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jul 3, 2024
@Michal-Szczepaniak
Copy link
Author

Can we please have it merged now, we've been at it for months :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@zvecr zvecr zvecr requested changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Michal-Szczepaniak @fauxpark @zvecr