Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add init function to RGBLight driver struct #23076

Merged
merged 8 commits into from
Mar 18, 2024
Merged

Add init function to RGBLight driver struct #23076

merged 8 commits into from
Mar 18, 2024

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Feb 14, 2024 •
edited
Loading

Description

Moved the initialisation code out of setleds() as it generally doesn't need to be checked/done every time the pixels are updated.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team February 14, 2024 02:38
zvecr
zvecr reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom drivers like https://github.com/qmk/qmk_firmware/blob/master/keyboards/kprepublic/bm60hsrgb/rev2/rev2.c#L167 are also going to need to be updated to call ws2812_init.

@fauxpark
Copy link
Member Author

Build failures due to oversize already present.

@fauxpark fauxpark requested a review from zvecr March 10, 2024 00:37
@fauxpark fauxpark merged commit f7cf40f into qmk:develop Mar 18, 2024
3 of 5 checks passed
@fauxpark fauxpark deleted the rgblight-driver-struct-init branch March 18, 2024 11:03
@daskygit daskygit mentioned this pull request Mar 24, 2024
Merged
14 tasks
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@fauxpark @mechlovin
Add init function to RGBLight driver struct (qmk#23076)
8e2bf6c
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@fauxpark @mechlovin
Add init function to RGBLight driver struct (qmk#23076)
4456e92
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 15, 2024
@fauxpark @mechlovin
Add init function to RGBLight driver struct (qmk#23076)
d78f549
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@fauxpark @whoisjordangarcia
Add init function to RGBLight driver struct (qmk#23076)
2c051e5
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@fauxpark @nuess0r
Add init function to RGBLight driver struct (qmk#23076)
a17dff4
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@fauxpark @Ardakilic
Add init function to RGBLight driver struct (qmk#23076)
6db2656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
core enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @tzarc @zvecr