Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Add Keyboard] Add the Infinity87 Rev3 #23082

Open
wants to merge 62 commits into
base: develop
Choose a base branch
from
Open

[Add Keyboard] Add the Infinity87 Rev3 #23082

wants to merge 62 commits into from
+1,620 −42

Conversation

mechlovin
Copy link
Contributor

Description

Add a IF87 Rev.3 PCB. APM32F103CBT6.
Thanks.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 15, 2024
dunk2k
dunk2k suggested changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add community layout support for rev3 variants
  • add EoF where missing
  • removed whitespace
  • changed last character in image URLs from l to h

keyboards/mechlovin/infinity87/rev3/rouge87/info.json Show resolved Hide resolved
keyboards/mechlovin/infinity87/rev3/rouge87/info.json Outdated Show resolved Hide resolved
keyboards/mechlovin/infinity87/rev3/rouge87/info.json Outdated Show resolved Hide resolved
keyboards/mechlovin/infinity87/rev3/rouge87/info.json Show resolved Hide resolved
keyboards/mechlovin/infinity87/rev3/rouge87/readme.md Outdated Show resolved Hide resolved
keyboards/mechlovin/infinity87/rev3/standard/info.json Outdated Show resolved Hide resolved
keyboards/mechlovin/infinity87/rev3/standard/mcuconf.h Show resolved Hide resolved
keyboards/mechlovin/infinity87/rev3/standard/info.json Outdated Show resolved Hide resolved
keyboards/mechlovin/infinity87/rev3/standard/info.json Show resolved Hide resolved
keyboards/mechlovin/infinity87/rev3/standard/info.json Show resolved Hide resolved
dunk2k
dunk2k suggested changes Feb 22, 2024
View reviewed changes
keyboards/mechlovin/infinity87/rev1/info.json Outdated Show resolved Hide resolved
keyboards/mechlovin/infinity87/rev1/standard/rules.mk Outdated Show resolved Hide resolved
keyboards/mechlovin/infinity87/rev2/keymaps/via/rules.mk Outdated Show resolved Hide resolved
keyboards/mechlovin/infinity87/rev2/matrix.c Outdated Show resolved Hide resolved
keyboards/mechlovin/infinity87/rev2/rules.mk Outdated Show resolved Hide resolved
keyboards/mechlovin/infinity87/rev3/standard/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/mechlovin/infinity87/rev3/standard/info.json Show resolved Hide resolved
keyboards/mechlovin/infinity87/rev3/standard/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/mechlovin/infinity87/rev3/standard/keymaps/via/keymap.c Show resolved Hide resolved
keyboards/mechlovin/infinity87/rgb_rev1/rules.mk Outdated Show resolved Hide resolved
dunk2k
dunk2k suggested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI Build fix:
ISO Hash and ANSI Backslash share same matrix co-ordinate

keyboards/mechlovin/infinity87/rev3/standard/info.json Outdated Show resolved Hide resolved
keyboards/mechlovin/infinity87/rev3/standard/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/mechlovin/infinity87/rev3/standard/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested review from a team and removed request for dunk2k March 2, 2024 06:29
dunk2k
dunk2k suggested changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting

keyboards/mechlovin/infinity87/rgb_rev1/rules.mk Outdated Show resolved Hide resolved
keyboards/mechlovin/infinity87/rev3/info.json Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team March 29, 2024 03:29
@github-actions github-actions bot added python cli qmk cli command labels Apr 12, 2024
@github-actions github-actions bot added dependencies and removed python cli qmk cli command labels Apr 12, 2024
mechlovin and others added 5 commits May 21, 2024 14:38
@mechlovin
add infinity87 rev3
6099c8d
@mechlovin @dunk2k
Update keyboards/mechlovin/infinity87/rev3/rouge87/info.json
db2d38a 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@mechlovin @dunk2k
Update keyboards/mechlovin/infinity87/rev3/rouge87/info.json
278e622 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@mechlovin @dunk2k
Update keyboards/mechlovin/infinity87/rev3/rouge87/readme.md
a742d1e 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@mechlovin @dunk2k
Update keyboards/mechlovin/infinity87/rev3/rouge87/info.json
f7e2998 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
mechlovin and others added 22 commits May 21, 2024 14:39
@mechlovin @dunk2k
Update keyboards/mechlovin/infinity87/rev3/info.json
aa6ec6f 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@mechlovin
move the matrix pin to config.h
a8873d2
@mechlovin
Update info.json
74b3902
@mechlovin @fauxpark
Update keyboards/mechlovin/infinity87/rev2/info.json
5728761 
Co-authored-by: Ryan <fauxpark@gmail.com>
@mechlovin
add infinity87 rev3
5ba5f1a
@mechlovin @dunk2k
Update keyboards/mechlovin/infinity87/rev3/readme.md
9f2d66e 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@mechlovin @dunk2k
Update keyboards/mechlovin/infinity87/rev3/standard/config.h
7839b04 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@mechlovin @dunk2k
Update info.json
ed888e7 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@mechlovin @dunk2k
Update readme.md
a645dd9 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@mechlovin @dunk2k
Update info.json
fdc9941 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@mechlovin @dunk2k
Update keymap.c
12ba2f0 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@mechlovin @dunk2k
Update keymap.c
01daf9e 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@mechlovin @dunk2k
Update keyboards/mechlovin/infinity87/rev3/standard/keymaps/via/keymap.c
36d8171 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@mechlovin @dunk2k
Update keyboards/mechlovin/infinity87/rev3/standard/keymaps/default/k…
6aea11e 
…eymap.c

Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@mechlovin @dunk2k
Update keyboards/mechlovin/infinity87/rev3/standard/info.json
018ca92 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@mechlovin @dunk2k
Update keyboards/mechlovin/infinity87/rev2/matrix.c
eb994ee 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@mechlovin
Delete keyboards/mechlovin/infinity87/rev3/rouge87/keymaps/default/re…
4962eaf 
…adme.md
@mechlovin
Delete keyboards/mechlovin/infinity87/rev3/standard/keymaps/default/r…
4fe7a33 
…eadme.md
@mechlovin
Delete keyboards/mechlovin/infinity87/rev3/standard/keymaps/via/readm…
967a90f 
…e.md
@mechlovin
move the matrix pin to config.h
53389da
@mechlovin
Update config.h
1135e0f
@mechlovin
Update info.json
afb3662
@mechlovin mechlovin requested a review from fauxpark May 21, 2024 14:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added stale Issues or pull requests that have become inactive without resolution. and removed stale Issues or pull requests that have become inactive without resolution. labels Jul 6, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k requested changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
dependencies keyboard keymap stale Issues or pull requests that have become inactive without resolution. via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mechlovin @drashna @fauxpark @dunk2k