Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build_test] set CONSOLE_ENABLE=yes if DEBUG > 0 #23097

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

DavidSannier
Copy link
Contributor

Description

make test:all DEBUG=1 also sets CONSOLE_ENABLE=yes
but make test:all DEBUG=2 or 3 does not
[The workaround was to add CONSOLE_ENABLE=yes for those values (make test:all DEBUG=3 CONSOLE_ENABLE=yes for example)]

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Feb 16, 2024
@drashna drashna requested a review from a team February 17, 2024 18:58
@DavidSannier
Copy link
Contributor Author

This pull request is based on commit 07aee9a for which make helix/rev3_5rows:via already fails with the following error:
The firmware is too large! 28992/28672 (320 bytes over)

Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Apr 10, 2024
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Apr 11, 2024
builddefs/build_test.mk Outdated Show resolved Hide resolved
Co-authored-by: Joel Challis <git@zvecr.com>
Copy link

github-actions bot commented Jul 3, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 3, 2024
@zvecr zvecr merged commit e07f752 into qmk:develop Jul 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants