Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hatsukey70 #23140

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Add Hatsukey70 #23140

wants to merge 24 commits into from

Conversation

interestor
Copy link

Description

I added a new keyboard named Hatsukey70.Keyboard directories, keymaps, etc.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • [ x ] Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [ x ] My code follows the code style of this project: C, Python
  • [ x ] I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [ x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 24, 2024
keyboards/hatsukey70/hatsukey70_via.json Outdated Show resolved Hide resolved
keyboards/hatsukey70/info.json Outdated Show resolved Hide resolved
keyboards/hatsukey70/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hatsukey70/keymaps/via/hatsukey70.json Outdated Show resolved Hide resolved
keyboards/hatsukey70/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/hatsukey70/readme.md Outdated Show resolved Hide resolved
keyboards/hatsukey70/readme.md Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team February 24, 2024 09:54
keyboards/hatsukey70/info.json Outdated Show resolved Hide resolved
keyboards/hatsukey70/info.json Outdated Show resolved Hide resolved
keyboards/hatsukey70/info.json Outdated Show resolved Hide resolved
keyboards/hatsukey70/info.json Outdated Show resolved Hide resolved
keyboards/hatsukey70/info.json Outdated Show resolved Hide resolved
keyboards/hatsukey70/readme.md Outdated Show resolved Hide resolved
keyboards/hatsukey70/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hatsukey70/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hatsukey70/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hatsukey70/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hatsukey70/keymaps/via/rules.mk Outdated Show resolved Hide resolved
keyboards/hatsukey70/readme.md Outdated Show resolved Hide resolved
keyboards/hatsukey70/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/hatsukey70/keymaps/default/keymap.c Outdated Show resolved Hide resolved
Copy link

github-actions bot commented May 6, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added stale Issues or pull requests that have become inactive without resolution. and removed stale Issues or pull requests that have become inactive without resolution. labels May 6, 2024
interestor and others added 12 commits May 7, 2024 11:17
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 22, 2024
keyboards/hatsukey70/rules.mk Outdated Show resolved Hide resolved
keyboards/hatsukey70/readme.md Outdated Show resolved Hide resolved
keyboards/hatsukey70/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/hatsukey70/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hatsukey70/info.json Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jun 23, 2024
interestor and others added 3 commits July 5, 2024 12:04
delete empty layer

Co-authored-by: Ryan <fauxpark@gmail.com>
delete empty layer

Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
keyboards/hatsukey70/rules.mk Outdated Show resolved Hide resolved
@interestor interestor requested review from zvecr and fauxpark July 8, 2024 05:52
Comment on lines +21 to +25
KC_GRV, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSPC,
KC_TAB, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_LBRC, KC_RBRC, KC_BSLS,
KC_CAPS, KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_H, KC_J, KC_K, KC_L, KC_SCLN, KC_QUOT, KC_ENT,
KC_LSFT, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, KC_UP, KC_RSFT,
MO(1), KC_LCTL, KC_LALT, KC_LGUI, KC_ESC, KC_SPC, KC_ENT, KC_BSPC, KC_RGUI, KC_RALT, KC_LEFT, KC_DOWN, KC_RIGHT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
KC_GRV, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSPC,
KC_TAB, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_LBRC, KC_RBRC, KC_BSLS,
KC_CAPS, KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_H, KC_J, KC_K, KC_L, KC_SCLN, KC_QUOT, KC_ENT,
KC_LSFT, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, KC_UP, KC_RSFT,
MO(1), KC_LCTL, KC_LALT, KC_LGUI, KC_ESC, KC_SPC, KC_ENT, KC_BSPC, KC_RGUI, KC_RALT, KC_LEFT, KC_DOWN, KC_RIGHT
KC_GRV, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSPC,
KC_TAB, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_LBRC, KC_RBRC, KC_BSLS,
KC_CAPS, KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_H, KC_J, KC_K, KC_L, KC_SCLN, KC_QUOT, KC_ENT,
KC_LSFT, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, KC_UP, KC_RSFT,
MO(1), KC_LCTL, KC_LALT, KC_LGUI, KC_ESC, KC_SPC, KC_ENT, KC_BSPC, KC_RGUI, KC_RALT, KC_LEFT, KC_DOWN, KC_RIGHT

Comment on lines +21 to +25
KC_GRV, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSPC,
KC_TAB, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_LBRC, KC_RBRC, KC_BSLS,
KC_CAPS, KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_H, KC_J, KC_K, KC_L, KC_SCLN, KC_QUOT, KC_ENT,
KC_LSFT, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, KC_UP, KC_RSFT,
MO(1), KC_LCTL, KC_LALT, KC_LGUI, KC_ESC, KC_SPC, KC_ENT, KC_BSPC, KC_RGUI, KC_RALT, KC_LEFT, KC_DOWN, KC_RIGHT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
KC_GRV, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSPC,
KC_TAB, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_LBRC, KC_RBRC, KC_BSLS,
KC_CAPS, KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_H, KC_J, KC_K, KC_L, KC_SCLN, KC_QUOT, KC_ENT,
KC_LSFT, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, KC_UP, KC_RSFT,
MO(1), KC_LCTL, KC_LALT, KC_LGUI, KC_ESC, KC_SPC, KC_ENT, KC_BSPC, KC_RGUI, KC_RALT, KC_LEFT, KC_DOWN, KC_RIGHT
KC_GRV, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSPC,
KC_TAB, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_LBRC, KC_RBRC, KC_BSLS,
KC_CAPS, KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_H, KC_J, KC_K, KC_L, KC_SCLN, KC_QUOT, KC_ENT,
KC_LSFT, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, KC_UP, KC_RSFT,
MO(1), KC_LCTL, KC_LALT, KC_LGUI, KC_ESC, KC_SPC, KC_ENT, KC_BSPC, KC_RGUI, KC_RALT, KC_LEFT, KC_DOWN, KC_RIGHT

@drashna drashna requested a review from a team July 15, 2024 05:17
@tzarc
Copy link
Member

tzarc commented Aug 26, 2024

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants