Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keymaps to momokai keyboards that switches debounce to asym_eager_defer_pk #23164

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add keymaps to momokai keyboards that switches debounce to asym_eager_defer_pk #23164

wants to merge 6 commits into from
+152 −0

Conversation

peepeetee
Copy link
Contributor

@peepeetee peepeetee commented Feb 28, 2024 •
edited
Loading

Description

This here pull request adds a keymap to each momokai keyboards that switches debounce to asym_eager_defer_pk

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@waffle87 waffle87 changed the base branch from master to develop February 28, 2024 15:45
@waffle87
Copy link
Member

Keyboard updates must target develop.

@peepeetee
Copy link
Contributor Author

Keyboard updates must target develop.

oh wow it's just changing the base branch I thought I would have to rebase it

@peepeetee peepeetee changed the title switch momokai keyboards default debounce to eager_pk switch momokai keyboards default debounce to asym_eager_defer_pk Feb 28, 2024
@peepeetee peepeetee changed the base branch from develop to master February 29, 2024 06:04
@peepeetee peepeetee changed the title switch momokai keyboards default debounce to asym_eager_defer_pk Add keymaps to momokai keyboards that switches debounce to asym_eager_defer_pk Feb 29, 2024
@peepeetee
Copy link
Contributor Author

Keyboard updates must target develop.

I have decided to make this change with a new keymap instead, and the pull request should reflect that now. from what I recall this should be able to target master now? so I changed base branch back to master for now

@github-actions github-actions bot removed the keyboard label Feb 29, 2024
@drashna drashna requested a review from a team March 29, 2024 03:41
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label May 14, 2024
@peepeetee
Copy link
Contributor Author

unstale

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label May 16, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 30, 2024
@peepeetee
Copy link
Contributor Author

unstale agin

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peepeetee @waffle87 @drashna