Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Keyboard Addition #23183

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

New Keyboard Addition #23183

wants to merge 21 commits into from
+111 −2

Conversation

MatchstickWorks
Copy link
Contributor

@MatchstickWorks MatchstickWorks commented Feb 29, 2024 •
edited
Loading

Description

Adding a new board to MatchstickWorks keyboards, NormiePad

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 29, 2024
@MatchstickWorks MatchstickWorks changed the base branch from develop to master February 29, 2024 05:38
@MatchstickWorks MatchstickWorks marked this pull request as ready for review February 29, 2024 05:41
@MatchstickWorks
Copy link
Contributor Author

The lint seems to be failing on a file that I didn't modify. Please advise?

@waffle87
Copy link
Member

The lint seems to be failing on a file that I didn't modify. Please advise?

No need to worry about it.

MatchstickWorks and others added 2 commits February 29, 2024 10:27
@MatchstickWorks @waffle87
Update keyboards/matchstickworks/normiepad/readme.md
da0f9e4 
Co-authored-by: jack <0x6a73@protonmail.com>
@MatchstickWorks @waffle87
Update keyboards/matchstickworks/normiepad/readme.md
88f256e 
Co-authored-by: jack <0x6a73@protonmail.com>
drashna
drashna requested changes Mar 2, 2024
View reviewed changes
keyboards/matchstickworks/normiepad/info.json Outdated Show resolved Hide resolved
keyboards/matchstickworks/normiepad/readme.md Outdated Show resolved Hide resolved
dunk2k
dunk2k suggested changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add EoF where missing

keyboards/matchstickworks/normiepad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/matchstickworks/normiepad/keymaps/via/keymap.c Outdated Show resolved Hide resolved
MatchstickWorks and others added 2 commits March 7, 2024 07:12
@MatchstickWorks @dunk2k
Update keyboards/matchstickworks/normiepad/keymaps/default/keymap.c
23665f2 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@MatchstickWorks @dunk2k
Update keyboards/matchstickworks/normiepad/keymaps/via/keymap.c
84fe721 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
MatchstickWorks and others added 3 commits March 29, 2024 14:18
@MatchstickWorks @drashna
Update keyboards/matchstickworks/normiepad/keymaps/default/keymap.c
6d9f126 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@MatchstickWorks @drashna
Update keyboards/matchstickworks/normiepad/keymaps/via/keymap.c
3f4c27c 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@MatchstickWorks @drashna
Update keyboards/matchstickworks/normiepad/info.json
3f79b3a 
Co-authored-by: Drashna Jaelre <drashna@live.com>
MatchstickWorks and others added 2 commits March 29, 2024 19:56
@MatchstickWorks @drashna
Update keyboards/matchstickworks/normiepad/info.json
8f946f2 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@MatchstickWorks @drashna
Update keyboards/matchstickworks/normiepad/keymaps/default/keymap.c
5a0f22d 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@MatchstickWorks @drashna
Update keyboards/matchstickworks/normiepad/keymaps/via/keymap.c
57a17c3 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@MatchstickWorks
Copy link
Contributor Author

Hey @drashna Could I get a re-review on this? I think the PR is still thinking a requested chance isn't resolved, but I believe we fixed it further down the discussion line.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 3, 2024
@MatchstickWorks
Copy link
Contributor Author

I am still waiting for a review from @drashna

It's unclear to me what still needs to be addressed with this PR.

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jul 4, 2024
fauxpark
fauxpark requested changes Jul 4, 2024
View reviewed changes
keyboards/matchstickworks/normiepad/info.json Outdated Show resolved Hide resolved
keyboards/matchstickworks/normiepad/rules.mk Outdated Show resolved Hide resolved
@MatchstickWorks @fauxpark
Update keyboards/matchstickworks/normiepad/keyboard.json
ed63139 
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@dunk2k dunk2k dunk2k requested changes

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MatchstickWorks @waffle87 @drashna @fauxpark @dunk2k