Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup work_board #23266

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Fixup work_board #23266

merged 2 commits into from
Mar 12, 2024
+31 −55

Conversation

waffle87
Copy link
Member

Description

  • Reduce VIA keymap firmware size (disable RGB Matrix animations)
  • Move some things to data driven
  • Tidy up misc code

Types of Changes

  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 12, 2024
@waffle87 waffle87 requested a review from a team March 12, 2024 17:54
@waffle87 @drashna
Update keyboards/work_louder/work_board/keymaps/default/keymap.c
1ce4908 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@waffle87 waffle87 merged commit aa33d8b into qmk:develop Mar 12, 2024
2 of 3 checks passed
@waffle87 waffle87 deleted the fix/work_board branch March 12, 2024 22:31
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@waffle87 @drashna @mechlovin
Fixup work_board (qmk#23266)
3a47e0f 
* initial

* Update keyboards/work_louder/work_board/keymaps/default/keymap.c

Co-authored-by: Drashna Jaelre <drashna@live.com>

---------

Co-authored-by: Drashna Jaelre <drashna@live.com>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@waffle87 @drashna @mechlovin
Fixup work_board (qmk#23266)
5e00f0c 
* initial

* Update keyboards/work_louder/work_board/keymaps/default/keymap.c

Co-authored-by: Drashna Jaelre <drashna@live.com>

---------

Co-authored-by: Drashna Jaelre <drashna@live.com>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 15, 2024
@waffle87 @drashna @mechlovin
Fixup work_board (qmk#23266)
17bacb0 
* initial

* Update keyboards/work_louder/work_board/keymaps/default/keymap.c

Co-authored-by: Drashna Jaelre <drashna@live.com>

---------

Co-authored-by: Drashna Jaelre <drashna@live.com>
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@waffle87 @drashna @whoisjordangarcia
Fixup work_board (qmk#23266)
8576d4d 
* initial

* Update keyboards/work_louder/work_board/keymaps/default/keymap.c

Co-authored-by: Drashna Jaelre <drashna@live.com>

---------

Co-authored-by: Drashna Jaelre <drashna@live.com>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@waffle87 @drashna @nuess0r
Fixup work_board (qmk#23266)
b20ccff 
* initial

* Update keyboards/work_louder/work_board/keymaps/default/keymap.c

Co-authored-by: Drashna Jaelre <drashna@live.com>

---------

Co-authored-by: Drashna Jaelre <drashna@live.com>
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@waffle87 @drashna @Ardakilic
Fixup work_board (qmk#23266)
2bc752d 
* initial

* Update keyboards/work_louder/work_board/keymaps/default/keymap.c

Co-authored-by: Drashna Jaelre <drashna@live.com>

---------

Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waffle87 @drashna @fauxpark