Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document syncing layer change callback across halves #23298

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

BlueDrink9
Copy link

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to weigh in on whether this is worth putting into the QMK docs one way or the other, but you might want to try this less-complex suggestion:

tzarc: In housekeeping keep track of the last seen state, if it changes invoke a callback?
tzarc: State is already synced as you said, compare and exec

@BlueDrink9
Copy link
Author

Thanks, just saw that. It looks like a better solution so I'll test.

I might keep this code but move it to the split docs, because more (and simpler) examples of how to use split comms will be helpful

Copy link

github-actions bot commented May 2, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label May 2, 2024
@BlueDrink9
Copy link
Author

waiting for a review after my last changes. Sorry, should probably have commented that they were made.

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label May 3, 2024
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 17, 2024
@BlueDrink9
Copy link
Author

Still waiting after fixing the image issue

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants