-
-
Notifications
You must be signed in to change notification settings - Fork 37.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document syncing layer change callback across halves #23298
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not going to weigh in on whether this is worth putting into the QMK docs one way or the other, but you might want to try this less-complex suggestion:
tzarc: In housekeeping keep track of the last seen state, if it changes invoke a callback?
tzarc: State is already synced as you said, compare and exec
Thanks, just saw that. It looks like a better solution so I'll test. I might keep this code but move it to the split docs, because more (and simpler) examples of how to use split comms will be helpful |
Thank you for your contribution! |
waiting for a review after my last changes. Sorry, should probably have commented that they were made. |
Thank you for your contribution! |
Still waiting after fixing the image issue |
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist