Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate keycode handling for LED Matrix and Backlight #23426

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Separate keycode handling for LED Matrix and Backlight #23426

merged 1 commit into from
Apr 11, 2024

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Apr 6, 2024

Description

The first puzzle piece. Keycodes are still shared; new ones for LED Matrix will come in the following PR.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team April 6, 2024 00:21
@fauxpark fauxpark mentioned this pull request Apr 7, 2024
Merged
14 tasks
@noroadsleft noroadsleft requested a review from a team April 9, 2024 07:22
@fauxpark fauxpark merged commit 25f608c into qmk:develop Apr 11, 2024
4 checks passed
@fauxpark fauxpark deleted the process-keycode-separate-led-matrix-backlight branch April 11, 2024 04:06
@fauxpark fauxpark mentioned this pull request Apr 11, 2024
Merged
14 tasks
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@fauxpark @whoisjordangarcia
Separate keycode handling for LED Matrix and Backlight (qmk#23426)
be101b0
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@fauxpark @nuess0r
Separate keycode handling for LED Matrix and Backlight (qmk#23426)
489adca
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@fauxpark @Ardakilic
Separate keycode handling for LED Matrix and Backlight (qmk#23426)
9cdc1eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @noroadsleft