Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial add of Layer Lock feature #23430

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Initial add of Layer Lock feature #23430

wants to merge 15 commits into from
+875 −2

Conversation

drashna
Copy link
Member

@drashna drashna commented Apr 6, 2024 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added core keyboard dd Data Driven Changes labels Apr 6, 2024
@getreuer
Copy link
Contributor

getreuer commented Jun 8, 2024

This is great! Thank you drashna for making this PR to add Layer Lock in QMK core. Please let me know if I can be of help.

@drashna
Copy link
Member Author

drashna commented Jun 9, 2024

This is great! Thank you drashna for making this PR to add Layer Lock in QMK core. Please let me know if I can be of help.

welcome! and mostly, I think I just need to write docs for this. The main issue being where to add them.

drashna and others added 2 commits June 9, 2024 12:29
@drashna
Update for newer version
9f2cc29
@getreuer
Add documentation to Layer Lock.
2c17619 
This commit builds on @drashna's qmk#23430
to add documentation:

* New page docs/features/layer_lock.md added describing Layer Lock.
* Added link to this page in docs/_sidebar.json
* And in docs/keycodes.md
* And a cross-reference in docs/feature_layers.md

NOTE: Beware, I haven't checked this documentation locally with `qmk
docs` (the command failed with a problem involving yarn). So there might
be formatting bugs and broken links in this.
@getreuer getreuer mentioned this pull request Jun 14, 2024
Merged
@drashna drashna marked this pull request as ready for review June 14, 2024 03:55
getreuer
getreuer reviewed Jun 14, 2024
View reviewed changes
quantum/quantum.h Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the keyboard label Jun 19, 2024
@drashna drashna requested a review from a team June 19, 2024 15:21
@getreuer
Copy link
Contributor

Nit: "I have updated the documentation accordingly" in the PR checklist can now be checked 👍

@getreuer getreuer mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getreuer getreuer getreuer approved these changes

Assignees
No one assigned
Labels
core dd Data Driven Changes documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drashna @getreuer